Fix #32 #34
Fix #32 #34
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Alright, I give up. This works fine locally, but not here. |
recipe/meta.yaml
Outdated
| number: 0 | ||
| script: | ||
| - export SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} | ||
| - {{ python }} -m pip install . --no-deps |
There was a problem hiding this comment.
Try putting this on a single line:
SETUPTOOLS_SCM_PRETEND_VERSION={{ version }} {{ python }} -m pip install . --no-deps
There was a problem hiding this comment.
Yea, I feel the same way. I think the short is we are going to recommend everyone to stay away from setuptools_scm for now.
There was a problem hiding this comment.
Yeah, I agree. It is pretty annoying to deal with as a downstream packager
There was a problem hiding this comment.
Needed toml... either way success!
|
@dopplershift Finally got this to work, please squash merge when you have the chance. |
* Fix the wrong v0.0.0 version number * Add @willschlitzer as recipe maintainer Reference: conda-forge/pint-feedstock#34
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)