-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for libhwloc 2.9.3 #141
Rebuild for libhwloc 2.9.3 #141
Conversation
…nda-forge-pinning 2024.01.24.19.49.09
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
BTW, now that we are at it, why don't we just cross-compile in linux-ppc64le as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cross-compiled linux builds are tested under emulation (unlike mac arm), so presumably that's confirmation that it is correct?
Since arm seems to be working, we could also try switching ppc to cross-compiled, which would save ~2 hours per build (not for this PR).
Interesting that you made it work, if the assumption holds it'd be nice to cross compile, see the earlier discussion here #121 (comment). |
Oh, boy... I didn't know cross-compiled packages were tested under emulation! |
268c560
to
24bc889
Compare
Note: this is because we set
@dalcinl Could you add a note to educate us how it was generated? I keep asking the original authors on both mpich/openmpi feedstocks and no one responded. If you figured it out, let's make sure I and future us know how to maintain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for two nits (update the deprecated config field and add comments).
…nda-forge-pinning 2024.01.25.13.56.16
24bc889
to
6523121
Compare
@leofang You are asking me to write down documentation. How dare you? |
Are the comments I added good enough? |
export ompi_cv_fortran_sizeof_type_test_mpi_handle_=4 | ||
export ompi_cv_fortran_true_value=1 | ||
export ompi_cv_fortran_use_only=yes | ||
export ompi_cv_real16_c_equiv=yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsquyres This is a very minor nit.. but ompi_cv_real16_c_equiv
is the only Fortran-related variable required for cross compiling that does not use a mpi_cv_fortran_
prefix (note the missing fortran_
bit). Would it make sense to rename it to follow the pattern of all the others variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Lisandro, LGTM!
For some reason the linux64 CI has failed repeatedly, seems related to some invalid utf-8 characters detected by LIEF at run time. |
What are we supposed to do? Should we try triggering a new build? |
Asking in the CF Gitter channel, let's see if anyone can help... I haven't seen this before |
Any news? Out of better ideas, I just restarted the build. |
Error reproduced in #142. |
!/recipe/** | ||
!/.ci_support/** | ||
|
||
# Since we ignore files/folders recursively, any folders inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leofang Maybe this change triggered some unintended consequence?
This PR has been triggered in an effort to update libhwloc293.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7645341919, please use this URL for debugging.