Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for new fontconfig macOS dylib compatibility version #10

Merged
merged 5 commits into from
Mar 17, 2022

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Mar 14, 2022

Cf conda-forge/fontconfig-feedstock#54 — changing the build system for Fontconfig dropped the fontconfig dylib's compatibility version, requiring users to rebuild.

I also made a few fixes to the build system that were exposed while testing the update.

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@pkgw pkgw requested a review from epruesse as a code owner March 14, 2022 19:32
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@pkgw pkgw force-pushed the fontconfig-rebuild branch from 09877d9 to 8f349fa Compare March 14, 2022 21:28
@jakirkham
Copy link
Member

Thoughts @conda-forge/openmotif? 🙂

@epruesse
Copy link
Member

Looks good to me. Thanks for all the work. Will squash and merge.

@epruesse epruesse merged commit 5cb1075 into conda-forge:main Mar 17, 2022
@pkgw pkgw deleted the fontconfig-rebuild branch March 18, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants