Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate pkg-config info on Windows #254

Closed
wants to merge 3 commits into from
Closed

Generate pkg-config info on Windows #254

wants to merge 3 commits into from

Conversation

auscompgeek
Copy link
Member

Checklist

I am attempting to build a Python package (robotpy-cscore) that uses OpenCV as a library on Windows. We use pkgconfig to find OpenCV, for OpenCV 4 compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@auscompgeek auscompgeek changed the title Generate pkg-config info on WindowsPatch 1 Generate pkg-config info on Windows Jan 2, 2021
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Jan 2, 2021

Thanks. Do you want to add a test to ensure that it is installed in the right location?

@auscompgeek
Copy link
Member Author

Sounds like a good idea. I've added a test command in what is hopefully a reasonable spot.

@auscompgeek
Copy link
Member Author

Well, it's a good thing I added that test. Hmm.

Upon closer inspection, it looks like OpenCV don't generate pkg-config info when building with MSVC:

https://github.com/opencv/opencv/blob/005508a07b42170e6a8d5f2ffba9aa5a1695054d/cmake/OpenCVGenPkgconfig.cmake#L1-L2

I wonder how one is supposed to discover include dirs on Windows then.

@auscompgeek
Copy link
Member Author

I guess I'll close this for now, since this doesn't actually do anything useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants