Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.0 #44

Merged
merged 10 commits into from
Jun 15, 2018
Merged

Conversation

jakirkham
Copy link
Member

Builds the very recent (and long awaited) release of OpenBLAS, 0.3.0. Likely still needs work, but putting it up to get that work and discussion started.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham mentioned this pull request May 23, 2018
@jakirkham
Copy link
Member Author

Looks like the CIs need some massaging here.

CircleCI is complaining about the build being too quiet. There is a no_output_timeout parameter which we can set to skirt this. We might consider setting this for all feedstocks ( conda-forge/conda-smithy#784 ).

Travis CI is complaining about the build being too noisy. Most of the warnings are about fabs being used when fabsl would be more appropriate. We could fix this with a patch or silence the warning. Some discussion about this in issue ( OpenMathLib/OpenBLAS#1357 ).

Surprisingly AppVeyor seems content even after dropping ~10 patches, which is amazing. Good work everyone that has been involved on the Windows build.

@isuruf
Copy link
Member

isuruf commented May 24, 2018

Travis CI is complaining about the build being too noisy.

No, travis-ci is also failing because of timeouts. New openblas versions has fewer warnings and hence no output.

@jakirkham
Copy link
Member Author

Yep. You’re right. I misread.

@jakirkham
Copy link
Member Author

Looks like adding logging information caused Travis CI to go over. 😩

Fortunately CircleCI seemed to work with this change. 🎉

Given this, am just switching the macOS builder to CircleCI. Not going to mess around with Travis CI's constraints on this one again. Doing this once when adding this recipe was enough for me.

@jakirkham jakirkham force-pushed the release_0.3.0 branch 3 times, most recently from c3dd881 to 4483f30 Compare May 26, 2018 07:57
jakirkham added 10 commits May 26, 2018 04:34
It appears that `clapack-src-CMakeLists.txt` was added and used as part
of the Windows build in commit (
005f3dc ). Usage of it was dropped on
Windows in commit ( 035d12d ). However
the file has hung around since. This drops `clapack-src-CMakeLists.txt`
as it is no longer used.
Sadly the CIs are being temperamental and refuse to build something that
is too quiet. As a result the OpenBLAS `make` step is being terminated
prematurely. To workaround this issue, try increasing the verbosity of
the `make` step. It is worth noting that this has gone over the CI log
length limits historically. So this may not work either. However it's
simple and worth trying. If it works, we will have better log
information from the OpenBLAS build, which is a good thing.
As we already drop Windows 32-bit, there is no need to skip it
specifically. So drop this redundant `skip`.
As we are running into tedious issues with Travis CI (log length limit,
quiet builds, etc.), switch to using CircleCI where these problem don't
seem to be blocking Linux. Hopefully this will extend to their macOS
builds as well.
Now that we have configured macOS builds to occur on CircleCI, re-render
so that the CI configuration files are updated accordingly.
Use the `compiler` syntax, split `build` and `host`, simplify Windows
`vc` stuff, drop hacky `perl` pin, etc.
After revamping the recipe, re-render to update pinnings and compiler
usage.
Builds on macOS will try to look for the `libgfortran` library during
the build. However as our compiler doesn't place that in the host
environment, macOS builds won't find it. This is demonstrated in the
linked log below. To fix this issue, just require `libgfortran-ng` be
installed in the host environment so that it can be linked to.
Admittedly this is a bit kludgy (though matches what we did previously);
however, this is something we have dealt with before when compiling on
macOS.

Linux can escape this problem as we provide `libgfortran` on the Docker
container. However to ensure it uses our `libgfortran`, go ahead and
include it there as well. This is what we did for Linux before. So it is
not too weird that we need to do it again.

ref: https://circleci.com/gh/conda-forge/openblas-feedstock/130
@jakirkham jakirkham changed the title WIP: Release 0.3.0 Release 0.3.0 May 26, 2018
@jakirkham
Copy link
Member Author

Would note there is a .dev in the SONAME, which is a little odd. ( OpenMathLib/OpenBLAS#1576 )

@jakirkham
Copy link
Member Author

Thoughts @conda-forge/openblas?

@jschueller
Copy link
Contributor

+1, what's the plan to update all the packages that link to openblas now, old school or conda 3 ?

@jakirkham
Copy link
Member Author

Move to conda-build 3 as well. We may also take the time to fix blas as we rebuild things.

xref: conda-forge/blas-feedstock#12

@jakirkham
Copy link
Member Author

Other thoughts?

@jakirkham
Copy link
Member Author

Ping?

host:
- libflang # [win]
- libgfortran-ng >=3.0 # [osx]
- libgfortran-ng >=4.9 # [linux]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the two lines above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It failed to build without these being present.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a log?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham
Copy link
Member Author

Anything else?

@jakirkham jakirkham merged commit acabc61 into conda-forge:master Jun 15, 2018
@jakirkham jakirkham deleted the release_0.3.0 branch June 15, 2018 13:41
@jakirkham
Copy link
Member Author

Thanks all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants