Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recipe to nvcomp 3.0.6. #14

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Update recipe to nvcomp 3.0.6. #14

merged 6 commits into from
Feb 23, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 23, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@bdice
Copy link
Contributor Author

bdice commented Feb 23, 2024

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Feb 23, 2024
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Feb 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@jakirkham jakirkham added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Feb 23, 2024
@jakirkham
Copy link
Member

Thanks Bradley! 🙏

This needs a fix to the skip. Currently it is building for CUDA 11.2 & 11.8. However we only need one

Let's keep CUDA 11.8 and skip 11.2 as the latter is going away in the not too distant future

@bdice
Copy link
Contributor Author

bdice commented Feb 23, 2024

@conda-forge-admin, please rerender

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Feb 23, 2024
@jakirkham
Copy link
Member

jakirkham commented Feb 23, 2024 •
edited
Loading

Seeing this error in the Linux ARM builds:

  ERROR (nvcomp,lib/libnvcomp.so): Needed DSO lib/libgomp.so.1 found in ['conda-forge/linux-aarch64::_openmp_mutex==4.5=2_gnu']
  ERROR (nvcomp,lib/libnvcomp.so): .. but ['conda-forge/linux-aarch64::_openmp_mutex==4.5=2_gnu'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

Edit: Reaching out offline

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 23, 2024 •
edited
Loading

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

This was referenced Feb 23, 2024
Merged
Merged
@jakirkham jakirkham removed the automerge Merge the PR when CI passes label Feb 23, 2024
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Feb 23, 2024
@github-actions github-actions bot merged commit 6108a14 into conda-forge:main Feb 23, 2024
7 checks passed
raydouglass pushed a commit to rapidsai/kvikio that referenced this pull request Feb 26, 2024
@bdice
Bump to nvcomp 3.0.6. (#346)
a72a105 
This PR bumps nvcomp to 3.0.6. This is needed as a hotfix for rapidsai/cudf#15096.

Depends on:
- conda-forge/nvcomp-feedstock#14
- rapidsai/rapids-cmake#542

Authors:
   - Bradley Dice (https://github.com/bdice)

Approvers:
   - Ray Douglass (https://github.com/raydouglass)
raydouglass pushed a commit to rapidsai/cudf that referenced this pull request Feb 27, 2024
@bdice
Bump to nvcomp 3.0.6. (#15128)
dc88dcb 
This PR bumps nvcomp to 3.0.6. This is needed as a hotfix for #15096.

Depends on:
- conda-forge/nvcomp-feedstock#14
- rapidsai/rapids-cmake#542
- rapidsai/kvikio#346

Authors:
   - Bradley Dice (https://github.com/bdice)

Approvers:
   - Lawrence Mitchell (https://github.com/wence-)
   - Ray Douglass (https://github.com/raydouglass)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adibbley adibbley Awaiting requested review from adibbley

@jakirkham jakirkham Awaiting requested review from jakirkham

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @jakirkham