-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for PyPy3.8 and PyPy3.9 #263
Rebuild for PyPy3.8 and PyPy3.9 #263
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@mattip, looks like there are 4 failures. |
These seem to be the same failures as in numpy/numpy#21285. Apparently there is an edge case in generic_aliases that we missed in testing before the release of PyPY3.9. I should have turned on |
Just a note that backporting the migrator to |
The PyPy issue has been fixed, I will update the PyPy feedstock. Once that percolates through we can restart CI here. |
…nda-forge-pinning 2022.04.03.14.32.43
9c7a025
to
55a512d
Compare
There seems to be some additional issues concerning numpy/numpy#17582 (which @mattip was involved with as well 🙃)... I had been wondering why pypy seemed to launch into the test suite twice, but it sounds like that is fully intentional. However, it makes the failures quite a bit harder to read, because now there are two separate test suite outputs (when failing). Here's some excerpts:
|
Since
|
This was surfaced by switching to running the full test suite in #267; if we want, we can obviously also skip |
|
I'm aware :)
We could pretty easily skip it using the existing I don't think pytest can do what you hypothesise, as it just collects the tests and runs them in order (i.e. not forming dependencies of "run A after B"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I think conda-forge/conda-forge-pinning-feedstock#2730 should be merged before this PR (but obviously I won't stand in the way if others disagree).
conda-forge/conda-forge-pinning-feedstock#2730 was merged, but the aarch64 and ppc packages need to be built manually before this can pass cleanly |
In addition to the aarch/ppc manual builds, this needs conda-forge/pypy-meta-feedstock#23 |
@conda-forge-admin, please restart ci |
Don't think the files are through the CDN yet (these days it seems to take ~2h most of the time; also #downloads>1 is a pretty reliable indicator). |
0b39f48
to
2e2b7b3
Compare
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
This PR has been triggered in an effort to update pypy38.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
This package has the following downstream children:
and potentially more.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2088171368, please use this URL for debugging.