-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable GEMMT with openblas, mkl #124
base: main
Are you sure you want to change the base?
Conversation
…and conda-forge-pinning 2024.09.05.15.59.11
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
so it's used in both build and test
561d7fd
to
ff5be2a
Compare
Openblas has the library, but libopenblas has the run_exports
I don't think it's actually needed, but the makefile tries to link LIBBLAS
47ce89f
to
eedf1dd
Compare
test shouldn't actually link libblas even though it's in the makefile
On my laptop (10 core M1 macbook), GEMMT does not appear to be worth it, at least for a simple poisson solve: OMP clearly gives a benefit in single-process solves (much less so in multiprocess, as expected), but at least openblas GEMMT doesn't seem to affect performance much, and when it does, the effect is not always positive. |
…and conda-forge-pinning 2024.09.09.07.32.13
9f376f8
to
40eb747
Compare
Apparently my test didn't actually exercise the GEMMT path, but when I try cholesky route that actually uses GEMMT, it's way slower, in fact. Not sure what's up with that. Trying with MKL as well. |
8a99ffa
to
a943a06
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
a943a06
to
3138099
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
adds build variant with openblas, with GEMMT enabled. As a result, installing mumps with openblas should get GEMMT by default. Installing mumps with any other blas should still get the most-compatible build targeting netlib.
closes #120
Draft because I'm still doing some performance testing to see if this is worth doing.