Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable GEMMT with openblas, mkl #124

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 6, 2024

adds build variant with openblas, with GEMMT enabled. As a result, installing mumps with openblas should get GEMMT by default. Installing mumps with any other blas should still get the most-compatible build targeting netlib.

closes #120

Draft because I'm still doing some performance testing to see if this is worth doing.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

so it's used in both build and test
Openblas has the library, but libopenblas has the run_exports
I don't think it's actually needed, but the makefile tries to link LIBBLAS
test shouldn't actually link libblas
even though it's in the makefile
@minrk
Copy link
Member Author

minrk commented Sep 9, 2024

On my laptop (10 core M1 macbook), GEMMT does not appear to be worth it, at least for a simple poisson solve:

visualization

visualization-2

OMP clearly gives a benefit in single-process solves (much less so in multiprocess, as expected), but at least openblas GEMMT doesn't seem to affect performance much, and when it does, the effect is not always positive.

@minrk minrk changed the title enable GEMMT with openblas enable GEMMT with openblas, mkl Sep 9, 2024
@minrk
Copy link
Member Author

minrk commented Sep 9, 2024

Apparently my test didn't actually exercise the GEMMT path, but when I try cholesky route that actually uses GEMMT, it's way slower, in fact. Not sure what's up with that. Trying with MKL as well.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build with GEMMT?
1 participant