-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include mamba in miniforge? #23
Comments
+1 sounds interesting. Looks like you read someone's mind here @SylvainCorlay, we had a discussion on this exact topic a few days ago:) To start with, are you thinking a set of installers based on |
I think you could also shove mamba into the base installer. Also, what would be really nice is if you could just configure the condarc file to use mamba whenever conda is called |
Just having it installed would allow people to use it, as an opt-in. |
mamba has a lot of different behaviour with conda that I don't want to replace. I used to use mamba and it updated my python version which took me a while to recover from and after 3 times I gave up. |
Do you have a minimal reproducer? |
Also, currently, from a fresh python 3.7 environment, |
I guess you have a reproducer. conda doesn't upgrade your python unless explicitly told to do so. |
this is conda. mamba behaves as expected on this one (and is much more reliable in my experience). |
And also mamba-org/mamba#38 |
thanks, I have responded to the individual tickets (marked 83 as a bug). |
This is interesting (and being resolved), but it seems orthogonal to including |
What hardware specs did you have trouble with? |
how do you currently install mamba? conda install mamba didn't work for me. |
|
IMHO |
@SylvainCorlay i've been playing aroudn with mamba + miniforge for the last few weeks. I noticed that it is recently poluting my directoris with |
@hmaarrfk that was a bug which is fixed. What version of mamba are you using? |
I guess I was on version I can confirm that updating to |
@wolfv as soon as TheSnakePit/mamba#83 is solved, i guess |
It would probably be possible to fix issue #83, although I think it's cleaner to install mamba in root. |
I'm still not convinced that we should include |
Perhaps build a |
how about |
I agree with the original rationale for this issue: |
I think |
+1. I like the name
Given that
Why should it be in root? |
@isuruf ... and what kind of systems are you working on then that you can't spare a hand full of MB's?!? |
If package size is a deal-breaker for some applications then maybe a separate package could work - |
I think we absolutely should have a community distro that includes mamba or micromamba. If we don't want that in miniforge, having a mambaforge that is also built as part of this repo would be fine with me |
That's fine with me. I suggested it in #23 (comment), but looks like @rgommers and @nerohmot wants it included in miniforge. |
If we're doing Mambaforge that'd work for me too. I think it's quite a bit more work and less ideal though - letting users choose at download time rather than later on seems sub-optimal. |
I think there is enough consensus to have a separate installer that we would feel comfortable merging in a PR to that effect. I do think that there are two user stories going on here.
We have 1 covered by miniforge and mambaforge. We don't really have 2 covered at all. I would be open to seeing proposals for a larger, more bloated, "just works" distribution. But that seems separate from the original issue here. |
I don't get this. Users can choose to install mamba later on. |
I think you're ignoring the downsides of letting users jump through a hoop like that and letting them deal with two package management tools. It's like, why have an installer that defaults to conda-forge, when users can simply download Miniconda and change a config file to then default to conda-forge. |
What are the chances of adding switches to the installer scripts ... something like :
|
If somebody volunteers, I'm okay. |
This |
That's a different issue #39 |
two flies one stone 😉 |
I think this is correct, which is that it goes alongside conda, and that we don't want to encourage users to install stuff in the base env. |
@minrk ran some benchmarks with mamba in repo2docker in a couple of repositories, and if we don't require a separate installation of mamba with conda, that will be a non-negligeable improvement in the binder build times (remove the green portion): |
It's always going to be a tradeoff between speed and storage. For binder, speed is important. For hosting in Heroku (where we host the webservice), storage is important. There's a 600MB limit in Heroku. (We switched to a different way in Heroku for the webservice and the storage is not an issue there anymore, but I've got another webapp using the older way) I'd prefer if people don't put their needs above others and work on a solution for everybody. |
Really not what I was doing, but adding some material on the interest of the question.
Hopefully, a micromamba-style installer will help with both speed and size eventually. |
There isn't too much automation in this repo. Maybe Mamba can take on releasing minimamba3?? |
My two cents to the debate. If disk size is an issue in certain cases I would expect speed to be really more important for the majority of the people (including me it's true but I don't think anybody here is trying to put their needs above others). It's true you can always install That being said those kinds of performance issues are also being looked at on the |
i'm becoming more and more convinced of mamba. We still dont have |
I am using it for a few months now. It has been a game changer for me. |
@hmaarrfk you can try boa, it has "conda mambabuild ..." and "boa build ..." where the boa native recipe format is slightly updated from the conda one. You can find working example recipes in the mamba-org/boa-forge repository if you're curious. |
I made a Draft PR that would built Mambaforge in addition to Miniforge on this repo: #70 |
Thanks for the effort @SylvainCorlay and @xhochy. I can confirm CI with |
We now have builds of miniforge available that include mamba (mambaforge). Closing. Thanks everyone! |
Mamba is much faster and consumes less memory than conda especially with large channels like conda-forge. This would solve the memory issues that a lot of people have experienced with e.g. RTD.
cc @wolfv
The text was updated successfully, but these errors were encountered: