-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to allow other build numbers of nifty and protobuf to be installed #25
Try to allow other build numbers of nifty and protobuf to be installed #25
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12423580550. Examine the logs at this URL for more detail. |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping The following suggestions might help debug any issues:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12420255842. Examine the logs at this URL for more detail. |
d47bba4
to
2e4cc5f
Compare
hmm we got much stricter in even ensuring that things can be solved... |
0ac7426
to
68030e7
Compare
…onda-forge-pinning 2024.12.20.00.45.05
ce7c256
to
41831b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would a user specify which of the two packages to install? Would they need to specify the exact hashes? Would there be a way to have a human readable way?
Something like micro_sam
(the default for unix-like without strict nifty pin) and micro_sam-win
(the stricter windows pin). Or would we need completely separate packages for this?
# against nifty | ||
# The unix package, specific to unix, has a less strict pin on nifty | ||
- nifty =1.2.1=*_4 # [osx] | ||
- protobuf <5 # [osx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for me to understand: you are using osx
here to build with a stricter pin because it would not build on win
due to missing pytorch. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. when i tried to build with win
it didn't work so well:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1115800&view=logs&j=fe7faf59-69bb-5487-b8fd-a35a7bda3a51&t=55731638-dd49-5144-2129-5101b9dd1960
this solution is in fact, very hacky...
They don't. This really isn't the conda(-forge) way.
yes.
Similar to https://github.com/computational-cell-analytics/micro-sam/blob/eb0def46d54a8e26758df05b5236f58fde8b56b9/workshops/i2k_2024/README.md?plain=1#L41C10-L41C85
(I can't say this enough, this is very fragile for many reasons). But specifying this is not necessary:
Conda-forge is not the right place to make hacks for this kind of thing. You fork this feedstock, use the CIs to upload whatever package you want to your own channel, but please don't do this kind of stuff at conda-forge. The hacks here are at the border of acceptable and may be deemed too much by other core members already... |
Hi @hmaarrfk , Let me know what you think (in that issue) and then I would start with implementing it later. |
I am closing this in favor of #26 . Thanks for the feedback on this! |
This creates 2 "noarch packages" to hack around the limitations that conda-forge does not have a pytorch package.
This is pretty "not ok" at conda-forge and I would recommend you don't give these kinds of hack instructions to your end users.
You can see my "comments" on the status of pytorch at conda-forge:
conda-forge/conda-forge.github.io#2381
-- hmaarrfk cc @hmaarrfk