-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LLVM-C.dll on Windows #213
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/llvmdev-feedstock/actions/runs/4980778126. |
@isuruf, I'd very much like your opinion here. The first point is whether we should set I see you added the I see from the build log that Footnotes |
PS. Thanks for the PR @metab0t! Sorry if this will still need some hashing out. |
@isuruf Would you like to give some feedback on this PR? |
Ping @isuruf. Might be good to figure this one out for the 17 cycle? |
This should be a separate output. |
in contrast to windows, it is off by default on osx; it's also not supported on linux
…nda-forge-pinning 2023.08.01.12.14.03
@isuruf, this is ready for review, PTAL. I refactored the installation scripts away from:
towards
which I think is clearer in intent and less error-prone, see 22fb387. This would be an independent improvement from this PR, but it makes sense in this context, because that way, it is a lot easier to extend for adding a libllvm-c output. |
Ping @isuruf if you want to review. Otherwise this follows your request of putting things in a separate output and I'll merge it in a few days. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes #212