Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM-C.dll on Windows #213

Merged
merged 9 commits into from
Aug 9, 2023
Merged

Conversation

metab0t
Copy link
Contributor

@metab0t metab0t commented May 15, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #212

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/llvmdev-feedstock/actions/runs/4980778126.

@conda-forge conda-forge deleted a comment from github-actions bot May 16, 2023
@h-vetinari
Copy link
Member

@isuruf, I'd very much like your opinion here. The first point is whether we should set LLVM_BUILD_LLVM_C_DYLIB=ON on osx as well (where, contrary to windows, it's off by default).

I see you added the =NO on windows in 8059f3a (though I don't see relevant comments in the corresponding PR). That commit is also relevant because it introduced another point about this recipe I'm not 100% sure about - currently on windows, libllvm16 & llvm are completely empty packages - I presume because this would be for the shared libraries which we're not building currently.

I see from the build log that Library/bin/LLVM-C.dll is shared though, so I wonder in which output this should go1. The unix version of the library will end up in libllvm16 AFAICT. Another, larger question is then whether we should try again to build the shared libraries on windows and populate libllvm16 also on windows.

Footnotes

  1. that said, llvmdev currently contains two DLLs on windows already, LTO.dll & Remarks.dll

@h-vetinari
Copy link
Member

PS. Thanks for the PR @metab0t! Sorry if this will still need some hashing out.

@metab0t
Copy link
Contributor Author

metab0t commented May 26, 2023

@isuruf Would you like to give some feedback on this PR?

@h-vetinari
Copy link
Member

Ping @isuruf. Might be good to figure this one out for the 17 cycle?

@isuruf
Copy link
Member

isuruf commented Jul 30, 2023

This should be a separate output. libllvm-c16

@h-vetinari
Copy link
Member

@isuruf, this is ready for review, PTAL. I refactored the installation scripts away from:

install then delete unwanted bits

towards

install into temporary prefix and copy specific files

which I think is clearer in intent and less error-prone, see 22fb387.

This would be an independent improvement from this PR, but it makes sense in this context, because that way, it is a lot easier to extend for adding a libllvm-c output.

@h-vetinari
Copy link
Member

Ping @isuruf if you want to review. Otherwise this follows your request of putting things in a separate output and I'll merge it in a few days.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Aug 9, 2023
@github-actions github-actions bot merged commit 55b747f into conda-forge:main Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LLVM-C.dll to build
3 participants