Bump version, add support for win #7
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
nehaljwani
force-pushed
the
bump-version-1.0.15
branch
3 times, most recently
from
210cb0c to
8e366e4
Compare
nehaljwani
force-pushed
the
bump-version-1.0.15
branch
from
8e366e4 to
7f8d4da
Compare
| run: | ||
| - vc 9 # [win and py27] | ||
| - vc 10 # [win and py34] | ||
| - vc 14 # [win and py>=35] |
There was a problem hiding this comment.
libsodium is only a C library. It shouldn't be running with a matrix of Python versions. It should only use one of these.
There was a problem hiding this comment.
@minrk pynacl uses libsodium and since we tie various python versions with various vc versions, I think we need to do this?
There was a problem hiding this comment.
Not sure, but this would probably also help:
https://lists.zeromq.org/pipermail/zeromq-dev/2014-October/027075.html
There was a problem hiding this comment.
So the matrix here is just to ensure the right VC runtime is used on Windows. This is important as different Python versions uses different VC runtimes. If a user ends up using two pieces of software built with different VC runtimes that share memory, file handles, or some other things, they will crash. So this is just trying to ensure the VC runtimes are properly aligned so that different linked software don't run into issues. That said we can instantiate this matrix with other mechanisms. Just turns out to be easiest with python.
|
Turns out CircleCI was failing. So this didn't get upload on Linux. Have just now fixed this issue. |
No description provided.