Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert S3 Support #188

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Revert S3 Support #188

merged 3 commits into from
Aug 30, 2023

Conversation

akrherz
Copy link
Contributor

@akrherz akrherz commented Aug 29, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Reverts S3 support added in #180 in hopes of helping #182 until a permanent fix can be found.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@akrherz
Copy link
Contributor Author

akrherz commented Aug 29, 2023

@conda-forge-admin please rerender

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akrherz, thanks for doing this. I think we need to revert this for now so we can make headway with migrations more broadly on conda-forge. Obviously, we can revisit this as soon as there's a fix, as folks are exploring in #182

@akrherz
Copy link
Contributor Author

akrherz commented Aug 30, 2023

Anybody willing to smash the green button here, so we can get migrations moving again?

@kmuehlbauer
Copy link
Contributor

@akherz It looks like we have consensus here. Thanks for doing the hard work.

@kmuehlbauer kmuehlbauer merged commit 2dc6848 into conda-forge:main Aug 30, 2023
@akrherz akrherz deleted the gh182_revert_s3 branch August 30, 2023 18:10
@akrherz
Copy link
Contributor Author

akrherz commented Aug 31, 2023

Again, a total FWIW and likely something I have screwed up, but I have found this updated build no longer does flakey things (segfaults, etc) on github actions with my own repos. I'll be sure to watch when S3 support comes back in the future and if flakey things happen then too or not.

@xylar
Copy link
Contributor

xylar commented Aug 31, 2023

Sounds promising! Let's hope when it comes back, it's more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants