Enable plugin install #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 27, 2023 16:34
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libnetcdf-feedstock/actions/runs/4533175882. |
added 6 commits
March 27, 2023 16:46
added 4 commits
March 29, 2023 10:22
…nda-forge-pinning 2023.03.29.08.25.52
zklaus
requested review from
WardF,
dopplershift,
groutr,
kmuehlbauer,
mingwandroid,
msarahan,
ocefpaf and
xylar
as code owners
dopplershift
approved these changes
Mar 29, 2023
WardF
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reset the build number to0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Fixes #174.
This installs the HDF5 filters that are shipped with Netcdf into the HDF5 default plugin directory, which is extracted from the HDF5 include file
H5pubconf.h.The plugins need to be installed to make the new compression features functional, but there are options on where to install them. We could designate a new directory for plugins shipped with Netcdf, say
$PREFIX/lib/netcdf-plugins/{hdf5,nczarr,}and make this known via theHDF5_PLUGIN_PATHenvironment variable in activate scripts. There is also the H5PL interface that allows for programmatic registration of plugin paths and that has been around at least since HDF5 1.8.Currently, upstream targets the default HDF5 plugin path as does this PR.
PS: Notably this risks clobbering parts of https://github.com/conda-forge/ccr-feedstock and https://github.com/conda-forge/blosc-hdf5-plugin-feedstock, which maybe useful if you want to use HDF5 with advanced compression without Netcdf.