Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create branch v8 for rebuild and minor releases of libignition-transport8 #18

Closed
wants to merge 3 commits into from

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 17, 2020

In particular with this change we backport the fix #17 to libignition-transport8 .
The build number was set to 2 as the latest build of libignition-transport8 8.1.0 was with build number 1 (see https://anaconda.org/conda-forge/libignition-transport8/files).

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@wolfv wolfv closed this Nov 17, 2020
@wolfv
Copy link
Member

wolfv commented Nov 17, 2020

I pushed this to the v8 branch in this repo: https://github.com/conda-forge/libignition-transport4-feedstock/tree/v8

Let's check in an hour if the packages arrive on anaconda.org :)

@traversaro
Copy link
Contributor Author

I pushed this to the v8 branch in this repo: https://github.com/conda-forge/libignition-transport4-feedstock/tree/v8

Let's check in an hour if the packages arrive on anaconda.org :)

Ah sorry, I created the v8 branch, but then I opened the PR against master.

@wolfv
Copy link
Member

wolfv commented Nov 17, 2020

yeah I don't even know if you can make a PR against a branch that doesn't exist... No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants