Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated filename for 1.0 version of Julia. #76

Closed
wants to merge 2 commits into from
Closed

Updated filename for 1.0 version of Julia. #76

wants to merge 2 commits into from

Conversation

krinsman
Copy link

@krinsman krinsman commented Aug 21, 2019

It seems that in the latest versions of Julia, juliarc.jl was renamed to startup.jl. So this is a minor patch. https://discourse.julialang.org/t/juliarc-jl-in-julia1-0/14354

This seems kind of self-explanatory but please let me know if I should clarify more of course.

See also: JuliaLang/julia#26161
and https://docs.julialang.org/en/v0.7.0/NEWS/

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@krinsman
Copy link
Author

krinsman commented Aug 21, 2019

Apparently LOAD_CACHE_PATH was deprecated at some point and replaced with DEPOT_PATH. Anyway references to a nonexistent Base.LOAD_CACHE_PATH were why the first version of this PR failed (as far as I can tell).

JuliaLang/julia#26165
JuliaLang/Compat.jl#527

I imagine this version will fail for different reasons but we'll see.

@krinsman
Copy link
Author

krinsman commented Aug 21, 2019

1. Looking at startup.jl, it looks like Base.source_path() would evaluate to ${PREFIX}/etc/julia/startup.jl, so that the value of JULIA_PREFIX (the variable in startup.jl) should be ${PREFIX}, and therefore JULIA_PKGDIR would evaluate to:

${PREFIX}/share/julia/site

which (for the version 1.0.2 release) would make the first entry of Base.DEPOT_PATH become:

${PREFIX}/share/julia/site/lib/v1.0

Presumably the first entry of Base.DEPOT_PATH should be the "root package directory", i.e. where all Julia packages installed by this installation of Julia are found/should be installed?

But doesn't this installation of Julia install packages to

${PREFIX}/share/julia/stdlib/v1.0

instead? So should that line in startup.jl be changed?

(Also should I have changed it to LOAD_PATH instead of DEPOT_PATH?)

2. Apparently Julia no longer uses the environment variable JULIA_PGKDIR with Pkg3/Julia v0.7+, so should the if statement checking for that variable be removed or replaced with something else?

(Since right now the condition is basically guaranteed to be false, which probably wasn't the intended behavior.)

Maybe it should say JULIA_LOAD_PATH or JULIA_DEPOT_PATH now? I don't actually understand the difference between the two variables as it is explained in the documentation.

@ngam ngam mentioned this pull request Dec 29, 2021
8 tasks
@ngam ngam closed this in #157 Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants