Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jinja2 compiler syntax #50

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR was created by the cf-regro-autotick-bot.

The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. It is very likely that the current package version for this feedstock is out of date or needed migration.

List of changes done to the recipe:
Renamed build with host
Removing toolchain in favour of compiler()
Moving cmake from host to build
Removing pinnings for zlib to use values from conda_build_config.yaml
Removing pinnings for python to use values from conda_build_config.yaml
Moving perl from host to build
Removing pinnings for openblas to use values from conda_build_config.yaml
Removing pinnings for gmp to use values from conda_build_config.yaml
Removing pinnings for mpfr to use values from conda_build_config.yaml
Removing pinnings for curl to use values from conda_build_config.yaml
Adding Fortran compiler
Adding C compiler
Adding C++ compiler

If you have recived a Migrate to Jinja2 compiler syntax PR from me recently please close that one and use this one.
Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.
    If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bgruening
Copy link
Contributor

Tests seems to be running too long.

@bgruening bgruening closed this Jul 14, 2018
@bgruening bgruening reopened this Jul 14, 2018
@dfornika
Copy link
Contributor

@bgruening Yes, this has been an ongoing issue with the julia recipe. Is there any way to give the tests more time?

@bgruening
Copy link
Contributor

@dfornika I remove the all-test, do you know if there are some other, smaller, tests which we can run? E.g. only unit-tests or something similar?

@mariusvniekerk
Copy link
Member

Why does julia have a python matrix?

recipe/meta.yaml Outdated
host:
- patchelf # [linux]
- zlib
- python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably move to build as - python 2.7*

@bgruening
Copy link
Contributor

@conda-forge-admin, please rerender
@mariusvniekerk done.

@mariusvniekerk mariusvniekerk merged commit 94fb0ef into conda-forge:master Jul 15, 2018
- {{ compiler('c') }}
- {{ compiler('cxx') }}
host:
- patchelf # [linux]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep this in build?

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the compiler_migration2 branch February 25, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants