-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing Downloads per mk request #163
Conversation
Co-authored-by: mkitti <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/julia-feedstock/actions/runs/1635119791. |
Local testing based on v1.7.1 linux64: 3 failures / errors:
|
406 save_env = get(ENV, "JULIA_SSL_NO_VERIFY_HOSTS", nothing)
407 delete!(ENV, "JULIA_SSL_NO_VERIFY_HOSTS")
408
409 @testset "bad TLS" begin
410 urls = [
411 "https://wrong.host.badssl.com"
412 "https://untrusted-root.badssl.com"
413 ]
414 @testset "bad TLS is rejected" for url in urls
415 resp = request(url, throw=false)
416 @test resp isa RequestError
417 @test resp.code == Curl.CURLE_PEER_FAILED_VERIFICATION
418 end
419 @testset "easy hook work-around" begin
420 local url
421 easy_hook = (easy, info) -> begin
422 Curl.set_ssl_verify(easy, false)
423 @test info.url == url
424 end
425 # downloader-specific easy hook
426 downloader = Downloader()
427 downloader.easy_hook = easy_hook
428 for outer url in urls
429 resp = request(url, throw=false, downloader=downloader)
430 @test resp isa Response
431 @test resp.status == 200
432 end
433 # default easy hook
434 Downloads.EASY_HOOK[] = easy_hook
435 Downloads.DOWNLOADER[] = nothing
436 for outer url in urls
437 resp = request(url, throw=false)
438 @test resp isa Response
439 @test resp.status == 200
440 end
441 Downloads.DOWNLOADER[] = nothing
442 Downloads.EASY_HOOK[] = nothing
443 end
444 ENV["JULIA_SSL_NO_VERIFY_HOSTS"] = "**.badssl.com"
445 @testset "SSL no verify override" for url in urls
446 resp = request(url, throw=false)
447 @test resp isa Response
448 @test resp.status == 200
449 end
450 delete!(ENV, "JULIA_SSL_NO_VERIFY_HOSTS")
451 end |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.12.29.09.38.02
@mkitti, I suspect this is a |
See upstream JuliaLang/Downloads.jl#139 |
This is an upstream issue. I propose closing this. Merging #157. Create a new PR from master pulling JuliaLang/julia@f61eb87 . Retest Downloads.jl. Inform upstream via the issue above if the issue is resolved. |
Okay, will do. |
Co-authored-by: mkitti [email protected]
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)