Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out-of-date scripts #140

Closed
wants to merge 2 commits into from

Conversation

mkitti
Copy link
Contributor

@mkitti mkitti commented Dec 11, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ngam ngam changed the title Fix out of date scripts Fix out-of-date scripts Dec 24, 2021
@ngam ngam mentioned this pull request Dec 24, 2021
@ngam
Copy link
Contributor

ngam commented Dec 24, 2021

What do we need to do here? Can you rebase with the current 1.7.1 so we could see what needs to be done with the latest update?

@mkitti
Copy link
Contributor Author

mkitti commented Dec 24, 2021

This is the bare minimum, comment out the line. JULIA_PKGDIR is not a currently used environmentally used variable. JULIA_DEPOT_PATH replaces it.

juliarc.jl is not currently used. It was replaced by ~/.julia/config/startup.jl.

https://docs.julialang.org/en/v1/manual/getting-started/#man-getting-started

Basically we could just delete recipe/juliarc.jl and recipe/pre-unlink.sh and just start over later. Neither of them currently work.

@ngam
Copy link
Contributor

ngam commented Dec 24, 2021

~/.julia/config/startup.jl

Do we provide this somewhere or is it bundled by julia?

@ngam ngam mentioned this pull request Dec 24, 2021
8 tasks
@ngam ngam closed this in #157 Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants