Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump/7.0.1 tests #58

Merged
merged 7 commits into from
Sep 29, 2018
Merged

Bump/7.0.1 tests #58

merged 7 commits into from
Sep 29, 2018

Conversation

bollwyvl
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Like #56 #57, this bumps to 7.0.1. I've also:

  • relaxed the python >=3 in favor of relying on skip
  • made the license tag SPDX-complian
  • added all the optional test dependencies (well, not x11)
  • run the tests

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor Author

(Oh, and i was getting fails with test_history on linux, so skipping for now...)

@blink1073
Copy link
Member

Looks like that same test fails on osx. Also, there is some subtlety about skip and noarch: https://conda-forge.org/docs/meta.html#building-noarch-packages

@bollwyvl
Copy link
Contributor Author

Yerp, let's pretend I let the second invocation of the tests run for demonstration purposes, and not that i forgot the windows selector 😊

  File "/home/conda/feedstock_root/build_artifacts/ipython_1538102512878/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.5/site-packages/IPython/core/tests/test_history.py", line 113, in test_history
    newhist[3]])
AssertionError: Lists differ: [(1, [51 chars]rn test'), (1, 3, "b='ƾ÷ß'"), (2, 1, 'z=5'), (2, 3, "k='p'")] != [(1, [51 chars]rn test'), (1, 3, "b='€Æ¾÷ß'"), (2, 3, "k='p'"), (2, 4, 'z=5')]

First differing element 3:
(2, 1, 'z=5')
(2, 3, "k='p'")

  [(1, 1, 'a=1'),
   (1, 2, 'def f():\n    test = 1\n    return test'),
   (1, 3, "b='€Æ¾÷ß'"),
-  (2, 1, 'z=5'),
-  (2, 3, "k='p'")]
?                 ^

+  (2, 3, "k='p'"),
?                 ^

+  (2, 4, 'z=5')]

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Sep 28, 2018

Also, there is some subtlety about skip and noarch:

Right, but we have plenty of platform-specific deps to worry about, other noarch dilemmas aside. I've recently been encountering issues like the one seen on appveyor where an output directory with the full python version spec, < and all, tries to get created on windows, but haven't dug much deeper:

OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\bld\\ipython_1538087828414\\work_moved_ipython-7.0.1-py>=3_0_win-64_main_build_loop'
Command exited with code 1

@bollwyvl
Copy link
Contributor Author

Here's a related report: conda/conda-build#3105

@bollwyvl
Copy link
Contributor Author

Well, that's OSX sorted!

@bollwyvl
Copy link
Contributor Author

Hadn't seen this before:

There was an error checking the latest version of pip
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/site-packages/pip/_internal/utils/outdated.py", line 90, in pip_version_check
    state = SelfCheckState(cache_dir=options.cache_dir)
  File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/site-packages/pip/_internal/utils/outdated.py", line 25, in __init__
    self.statefile_path = os.path.join(cache_dir, "selfcheck.json")
  File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/posixpath.py", line 89, in join
    genericpath._check_arg_types('join', a, *p)
  File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/genericpath.py", line 143, in _check_arg_types
    (funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'bool'

@bollwyvl
Copy link
Contributor Author

Great, now the long dark of the appveyor queue... really hope it passes there :P

@blink1073 blink1073 mentioned this pull request Sep 28, 2018
5 tasks
@blink1073
Copy link
Member

@bollwyvl, nope ☹️

@blink1073
Copy link
Member

@blink1073
Copy link
Member

cf dabeaz/curio#210

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Sep 28, 2018 via email

@bollwyvl
Copy link
Contributor Author

Yep, tests worked the first time locally without any skips. 🤞

@bollwyvl
Copy link
Contributor Author

Added #44 while waiting...

@blink1073
Copy link
Member

blink1073 commented Sep 28, 2018

Why not add you and I as maintainers while we're at it?

@bollwyvl
Copy link
Contributor Author

Why not add yourself and me as maintainers while we're at it?

copy. killed the first appveyor job, since it would die anyway

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Sep 28, 2018 via email

@Carreau
Copy link
Contributor

Carreau commented Sep 29, 2018

All green! Quick, someone press merge before it changes it's mind!

Damn if only you were maintainer...

@Carreau Carreau merged commit 0368e41 into conda-forge:master Sep 29, 2018
@blink1073
Copy link
Member

🎉

@bollwyvl bollwyvl deleted the bump/7.0.1-tests branch September 29, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants