-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump/7.0.1 tests #58
Bump/7.0.1 tests #58
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
(Oh, and i was getting fails with |
Looks like that same test fails on osx. Also, there is some subtlety about skip and noarch: https://conda-forge.org/docs/meta.html#building-noarch-packages |
Yerp, let's pretend I let the second invocation of the tests run for demonstration purposes, and not that i forgot the windows selector 😊 File "/home/conda/feedstock_root/build_artifacts/ipython_1538102512878/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.5/site-packages/IPython/core/tests/test_history.py", line 113, in test_history
newhist[3]])
AssertionError: Lists differ: [(1, [51 chars]rn test'), (1, 3, "b='€Æ¾÷ß'"), (2, 1, 'z=5'), (2, 3, "k='p'")] != [(1, [51 chars]rn test'), (1, 3, "b='€Æ¾÷ß'"), (2, 3, "k='p'"), (2, 4, 'z=5')]
First differing element 3:
(2, 1, 'z=5')
(2, 3, "k='p'")
[(1, 1, 'a=1'),
(1, 2, 'def f():\n test = 1\n return test'),
(1, 3, "b='€Æ¾÷ß'"),
- (2, 1, 'z=5'),
- (2, 3, "k='p'")]
? ^
+ (2, 3, "k='p'"),
? ^
+ (2, 4, 'z=5')] |
Right, but we have plenty of platform-specific deps to worry about, other
|
Here's a related report: conda/conda-build#3105 |
Well, that's OSX sorted! |
Hadn't seen this before: There was an error checking the latest version of pip
Traceback (most recent call last):
File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/site-packages/pip/_internal/utils/outdated.py", line 90, in pip_version_check
state = SelfCheckState(cache_dir=options.cache_dir)
File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/site-packages/pip/_internal/utils/outdated.py", line 25, in __init__
self.statefile_path = os.path.join(cache_dir, "selfcheck.json")
File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/posixpath.py", line 89, in join
genericpath._check_arg_types('join', a, *p)
File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/genericpath.py", line 143, in _check_arg_types
(funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'bool' |
Great, now the long dark of the appveyor queue... really hope it passes there :P |
@bollwyvl, nope |
Ah curio is not available on Windows: https://github.com/conda-forge/curio-feedstock/blob/master/recipe/meta.yaml#L18 |
Well, shucks. I'll test on some real iron right now and get that selector
added and any test skips...
|
Yep, tests worked the first time locally without any skips. 🤞 |
Added #44 while waiting... |
Why not add you and I as maintainers while we're at it? |
copy. killed the first appveyor job, since it would die anyway |
All green! Quick, someone press merge before it changes it's mind!
|
Damn if only you were maintainer... |
🎉 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Like #56 #57, this bumps to
7.0.1
. I've also:python >=3
in favor of relying onskip