Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default stdlib requirement to mkl #84

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Nov 9, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

As mentioned by @h-vetinari at https://github.com/conda-forge/intel_repack-feedstock/pull/82/files/462540bf2bc86a600f7be112379d6def0ce68859#r1835172927 there was an error with setting correct glibc dependency

@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Nov 9, 2024

Thank you @h-vetinari for finding the issue. Could you please review this PR?

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 9, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@oleksandr-pavlyk
Copy link
Contributor

Just making sure that change to replace - {{ c_stdlib }}_{{ target_platform }} >={{ c_stdlib_sycl_version }} # [linux] with - {{ c_stdlib }}_{{ target_platform }} {{ c_stdlib_sycl_version }} # [linux] was purely stylistic.

The real issue was that {{ c_stdlib_sycl_version }} was used in non-SYCL components, i.e., mkl.

@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Nov 9, 2024

Just making sure that change to replace - {{ c_stdlib }}_{{ target_platform }} >={{ c_stdlib_sycl_version }} # [linux] with - {{ c_stdlib }}_{{ target_platform }} {{ c_stdlib_sycl_version }} # [linux] was purely stylistic.

The real issue was that {{ c_stdlib_sycl_version }} was used in non-SYCL components, i.e., mkl.

Yes, exactly. I've checked that removing >= does not affect result glibc pinning

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing it @ZzEeKkAa

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response!

@ZzEeKkAa ZzEeKkAa merged commit c00af86 into conda-forge:main Nov 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants