-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable SIMD optimizations #107
feat: Enable SIMD optimizations #107
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
* Add x86_64-microarch-level as a 'build' requirement. - microarch_level 4 not supported yet so only add level 1 to 3. * Set the build number based on the microarch_level. * Add conda_build_config.yaml with microarch_level. * c.f. https://prefix.dev/blog/building_cpu_optimized_packages * Bump build number.
f8c62a0
to
e5501cd
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.09.07.19.33.02
@conda-forge/iminuit this is ready for review. Let me know if you have any questions. 👍 |
Do you know if PR's are actually making anything faster? Some code bases can effectively use vector instructions and get a nice 2x+ speed up and some don't see much benefit. |
@henryiii Good question. I don't have any explict checks to show at the moment. I'll defer to you if you think this is worth doing here (and for the other ones that I've opened up), and if so I'll do some custom builds and test comparisons when I'm back from work travel in a few weeks. |
Placed into draft given that needs to be rebased following PR #108 and needs conda-forge/microarch-level-feedstock#10 to be resolved before can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot review this, but I appreciate the effort and I think it sound all good.
That being said, iminuit will not profit from such optimizations, because the minimizing algorithm is typically not the bottleneck, it is the calculation of the cost function, which ideally should be JIT-compiled for the specific architecture. |
Sounds good. No need to add more build complexity if it won't help, so closing this. 👍 Thanks, Hans, for the info! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)