Rebuild for occt76 #20

regro-cf-autotick-bot · 2022-01-13T20:06:05Z

This PR has been triggered in an effort to update occt76.

Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1694372988, please use this URL for debugging.}

…nda-forge-pinning 2022.01.13.01.57.35

conda-forge-linter · 2022-01-13T20:06:09Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo · 2022-04-01T08:45:11Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2022.04.01.00.07.17

looooo · 2022-04-01T08:47:43Z

@aothms is ifcopenshell ready for occt7.6? which branch to use?

luzpaz · 2022-04-03T12:48:52Z

Ping
@aothms (IfcOpenShell)
@Moult (BlenderBim-Addon)
@wassimj (https://github.com/wassimj/Topologic)

We're trying to update OCC 7.6.1 in conda.

aothms · 2022-04-04T08:59:49Z

Thank you for this.

I just committed the last 7.6 compatibility fix to the v0.7.0 branch. IfcOpenShell/IfcOpenShell@461b786

A quick heads up v0.7 has a bunch of additional dependencies:

hdf5, cgal (hence gmp [or equivalent mpir on windows], mpfr)

We can do an initial version without (would require some fixes on my side to make them optional). But they are really quite nice to have: hdf5 for caching, cgal (Arrangement_2) for drawing generation. I think the BIM workbench might want to use them over time.

Only a handful of users has tested yet with 7.6.
IfcOpenShell has a continuous development model basically. At some point we had some issues with v0.6.0 where we should have used some postfix to the version number. Like alpha 0 or whatever. Hope that can be arranged. If I need to tag something on the side of the IfOpSh repo, please let me know.

looooo · 2022-04-04T11:17:16Z

@aothms
cgal hdf5 and mpfr are available from conda-forge:
https://anaconda.org/conda-forge/cgal
https://anaconda.org/conda-forge/hdf5
https://anaconda.org/conda-forge/mpfr

so I will try to switch to v0.7.0

If it is possible a alpha version would make a lot of sense to me.

luzpaz · 2022-04-09T23:31:10Z

bump

aothms · 2022-04-10T07:21:06Z

Were you waiting for my tag? Just pushed v0.7.0-alpha0 https://github.com/IfcOpenShell/IfcOpenShell/tree/v0.7.0-alpha0

wassimj · 2022-04-10T11:22:10Z

hi everyone. I just did a pre-release of topologic for occt 7.6.0. It seems to work fine, but is not tested.
https://github.com/wassimj/TopologicSverchok/releases/tag/v0.8.1.0-alpha

looooo · 2022-04-10T14:09:09Z

@aothms can you rename the version? I get this error:
Error: bad character '-' in package/version: v0.7.0-alpha0

I can also adresse this somehow in the feedstock, but I guess it's not the best option to keep the - in the version-name.

aothms · 2022-04-10T14:20:38Z

Ok, actually the convention we had was a postfixed with a number instead of -alpha anyway. So can you try again with v0.7.0a0 https://github.com/IfcOpenShell/IfcOpenShell/releases/tag/v0.7.0a0 Thanks

looooo · 2022-04-10T14:50:54Z

ok, now I am getting this one:

CMake Error at CMakeLists.txt:843 (ADD_SUBDIRECTORY):
  The source directory

    /home/conda/feedstock_root/build_artifacts/ifcopenshell_1649601640487/work/src/svgfill

  does not contain a CMakeLists.txt file.

is this a subrepo?

aothms · 2022-04-10T18:40:22Z

is this a subrepo?

yes

There is also a recipe under development btw within the ifcopenshell repo, maybe for inspiration: IfcOpenShell/IfcOpenShell#2132

Might be that we'll be running into similar issues because the expectations in the 0.7 cmake file are a bit specific

looooo · 2022-04-28T10:21:44Z

@aothms is it possible to include the subrepos in the release?

aothms · 2022-04-28T10:25:44Z

@looooo I think this requires using git_url instead of url the github tar archives never include submodules.

conda-forge-linter · 2022-04-30T21:37:16Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The source section contained an unexpected subsection name. git-url is not a valid subsection name.
The source section contained an unexpected subsection name. git-tag is not a valid subsection name.

conda-forge-linter · 2022-04-30T21:38:59Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo · 2022-08-11T16:28:24Z

thanks for your review @Krande . The osx issue was resolved by @aothms for the main branch of IfcOpenShell. IIRC there was an issue with the submodules.

Krande · 2022-08-12T06:31:21Z

Okay, I think I might have a suggestion to try to fix the OSX build (for the sake of testing the OSX builds).

Try specifying a shallow git_depth by changing the source definition in the meta.yaml file

from

source:
  git_url: https://github.com/Krande/IfcOpenShell
  git_tag: pr-daily-builds
  # sha256: ad488046939bf281025a75f8c656db9dc89a54d8b6539f8169acabba90f6a8ac

to

source:
  git_url: https://github.com/Krande/IfcOpenShell
  git_tag: pr-daily-builds
  git_depth: 1
  # sha256: ad488046939bf281025a75f8c656db9dc89a54d8b6539f8169acabba90f6a8ac

ref: https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#source-from-git

Krande · 2022-08-12T08:45:27Z

Hm, my bad :/ It seems that using git_tag pointing to a git branch + setting git_depth is not a valid solution.

Maybe I should just finalize my PR IfcOpenShell/IfcOpenShell#2132 and once that's done then @aothms can create a new tag which you can use?

looooo · 2022-08-14T07:37:54Z

thanks @Krande for the continued support. Please ping me once the PR is merged.

Krande · 2022-08-15T15:06:50Z

@looooo The PR is merged and I have made a new tag "v0.7.0a4" which I think you should be able to use with the original Ifcopenshell repo.

Krande · 2022-08-20T06:10:13Z

Ping @looooo.

(In case my previous ping did not reach you:))

looooo · 2022-08-20T08:31:18Z

@Krande thanks for the ping :)

Krande · 2022-08-20T10:47:42Z

recipe/meta.yaml

+  git_url: https://github.com/Krande/IfcOpenShell
+  git_tag: pr-daily-builds
+  git_depth: 1


@looooo I think this part can be reverted back to the original Ifcopenshell repo now that my PR is complete. I am not sure where you find the relevant sha256 tag, but here's the tagged release: https://github.com/IfcOpenShell/IfcOpenShell/releases/tag/v0.7.0a4

Krande · 2022-08-20T12:21:08Z

@looooo If you think it might help you could add me as a maintainer and I could try to help fix the meta.yaml?

looooo · 2022-08-22T06:54:55Z

@Krande done, but I guess you will be able to work on the feedstock once the PR is merged. Currently only the osx-builds are not working due to some git issues.

Krande · 2022-08-23T13:15:37Z

@looooo

Okay, how about we use the url and sha256 of the tagged release v0.7.0a4 like this?

source:
  url: https://github.com/IfcOpenShell/IfcOpenShell/archive/refs/tags/{{ version }}.tar.gz
  sha256: e789a4545de50aae064ac2f3568ee41673c4391ab78751a4a034b7ca5a9a149e

Btw: As you said, I seem to be unable to push :) So I can probably be more helpful on the next PR!

looooo · 2022-08-23T13:34:09Z

@Krande not sure if the subrepos are included if I use the zipped source. But I will try.

yes, as I expected, the subrepos are not included.

Krande · 2022-08-23T13:48:15Z

Ah, you're right. The submodules aren't included in the release files:(

I will take another look at it later today

looooo · 2022-08-23T13:53:36Z

@Krande I try to add the other repos too. Conda allows to specify multiple sources.

conda-forge-linter · 2022-08-23T13:59:21Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
The source section contained an unexpected subsection name. sha256sum is not a valid subsection name.
The source section contained an unexpected subsection name. sha256sum is not a valid subsection name.
The source section contained an unexpected subsection name. sha256sum is not a valid subsection name.
The source section contained an unexpected subsection name. sha256sum is not a valid subsection name.

conda-forge-linter · 2022-08-23T14:04:33Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Krande · 2022-08-23T15:23:20Z

You're very close I think.

In the meta.yaml I think the SHA256 was accidentally copy-pasted from the ifcopenshell/files repo to python-mvdxml.

So you should get 1 step closer by simply changing

this

  - url: https://github.com/opensourceBIM/python-mvdxml/archive/83c12fa494b9d6a5a370d8525dc1f76aa5c89d8d.tar.gz
    folder: src/ifcopenshell-python/ifcopenshell/mvd
    sha256: 2bf8cabd6364fbb09b4e7351397beb631d47d9574ee89c98510066acec3a58ac

to this

  - url: https://github.com/opensourceBIM/python-mvdxml/archive/83c12fa494b9d6a5a370d8525dc1f76aa5c89d8d.tar.gz
    folder: src/ifcopenshell-python/ifcopenshell/mvd
    sha256: 3a332aae707967e609dcab44a118a88ec270c551e7222eb53fc8ba809e9e7a0d

Krande · 2022-08-24T08:12:29Z

@looooo Great progress!

I see that we're running into the following error now:

[851/862] Building CXX object svgfill/CMakeFiles/libsvgfill.dir/src/svgfill.cpp.o
FAILED: svgfill/CMakeFiles/libsvgfill.dir/src/svgfill.cpp.o 
$BUILD_PREFIX/bin/x86_64-conda-linux-gnu-c++ -DBOOST_ALL_NO_LIB -DHAS_SCHEMA_2x3 -DHAS_SCHEMA_4 -DHAS_SCHEMA_4x1 -DHAS_SCHEMA_4x2 -DHAS_SCHEMA_4x3 -DHAS_SCHEMA_4x3_rc1 -DHAS_SCHEMA_4x3_rc2 -DHAS_SCHEMA_4x3_rc3 -DHAS_SCHEMA_4x3_rc4 -DSCHEMA_SEQ="(2x3)(4)(4x1)(4x2)(4x3_rc1)(4x3_rc2)(4x3_rc3)(4x3_rc4)(4x3)" -DWITH_HDF5 -DWITH_IFCXML -I$PREFIX/include/opencascade -I$PREFIX/include/libxml2 -I$SRC_DIR/src/svgfill/3rdparty/svgpp/include -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/ifcopenshell-v0.7.0a4 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -O3 -DNDEBUG   -Wall -Wextra -Wno-maybe-uninitialized -Wno-deprecated-copy -fPIC -std=gnu++17 -MD -MT svgfill/CMakeFiles/libsvgfill.dir/src/svgfill.cpp.o -MF svgfill/CMakeFiles/libsvgfill.dir/src/svgfill.cpp.o.d -o svgfill/CMakeFiles/libsvgfill.dir/src/svgfill.cpp.o -c $SRC_DIR/src/svgfill/src/svgfill.cpp
$SRC_DIR/src/svgfill/src/svgfill.cpp:25:10: fatal error: svgpp/svgpp.hpp: No such file or directory

Which is due to the svgfill also uses a submodule :)

from the svgfill .gitmodule file

[submodule "3rdparty/svgpp"]
	path = 3rdparty/svgpp
	url = https://github.com/svgpp/svgpp

So try adding this to the meta.yaml?

  - url: https://github.com/svgpp/svgpp/archive/15da1891e576e8ef66dbe90e8e1a776dccea889d.tar.gz
    folder: src/svgfill/3rdparty/svgpp
    sha256: 5364b6a2d49c37fe3d0669366ec07348378868d1f0d94674cd1af97229adc558

regro-cf-autotick-bot added 2 commits January 13, 2022 20:05

Rebuild for occt76

f8ca1da

MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.16.1, and co…

ddfb53a

…nda-forge-pinning 2022.01.13.01.57.35

regro-cf-autotick-bot requested a review from looooo as a code owner January 13, 2022 20:06

MNT: Re-rendered with conda-build 3.21.8, conda-smithy 3.19.0, and co…

d6b3135

…nda-forge-pinning 2022.04.01.00.07.17

Update version to v0.7.0.

9b76cb3

update download link + sha256sum

7d5d448

update version name

271bded

This was referenced Apr 11, 2022

Get ifcopenshell in to homebrew FreeCAD/homebrew-freecad#97

Open

OCC 7.6 IfcOpenShell/IfcOpenShell#1883

Closed

use git-url

66e2bfe

git_url

50c6ffd

looooo added 2 commits April 30, 2022 23:45

update url

7acb8b7

use tag

fc5ad7e

Update meta.yaml

104e501

update to v0.7.0a4

6e82a36

Krande reviewed Aug 20, 2022

View reviewed changes

Update meta.yaml

7a67922

looooo added 2 commits August 21, 2022 14:04

Update meta.yaml

d9b015d

add maintainer

5abb671

use zipped source

2d82964

add other sources

527bd17

update sha256sum

fff3c53

Update sha256 sum

ffa9f4c

Add svgpp

afedf83

looooo merged commit 23a7775 into conda-forge:main Aug 24, 2022

regro-cf-autotick-bot deleted the rebuild-occt76-0-1_hb39e9c branch August 24, 2022 14:07

Rebuild for occt76 #20

Rebuild for occt76 #20

Conversation

regro-cf-autotick-bot commented Jan 13, 2022

conda-forge-linter commented Jan 13, 2022

looooo commented Apr 1, 2022

looooo commented Apr 1, 2022

luzpaz commented Apr 3, 2022

aothms commented Apr 4, 2022

looooo commented Apr 4, 2022

luzpaz commented Apr 9, 2022

aothms commented Apr 10, 2022

wassimj commented Apr 10, 2022

looooo commented Apr 10, 2022

aothms commented Apr 10, 2022

looooo commented Apr 10, 2022

aothms commented Apr 10, 2022

looooo commented Apr 28, 2022

aothms commented Apr 28, 2022

conda-forge-linter commented Apr 30, 2022

conda-forge-linter commented Apr 30, 2022

looooo commented Aug 11, 2022

Krande commented Aug 12, 2022

Krande commented Aug 12, 2022

looooo commented Aug 14, 2022

Krande commented Aug 15, 2022 • edited Loading

Krande commented Aug 20, 2022

looooo commented Aug 20, 2022

Krande Aug 20, 2022

Choose a reason for hiding this comment

Krande commented Aug 20, 2022

looooo commented Aug 22, 2022

Krande commented Aug 23, 2022 • edited Loading

looooo commented Aug 23, 2022 • edited Loading

Krande commented Aug 23, 2022

looooo commented Aug 23, 2022

conda-forge-linter commented Aug 23, 2022

conda-forge-linter commented Aug 23, 2022

Krande commented Aug 23, 2022 • edited Loading

Krande commented Aug 24, 2022

Krande commented Aug 15, 2022 •

edited

Loading

Krande commented Aug 23, 2022 •

edited

Loading

looooo commented Aug 23, 2022 •

edited

Loading

Krande commented Aug 23, 2022 •

edited

Loading