New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to rebuild 1.14.3 #241

Merged

hmaarrfk merged 2 commits into conda-forge:1.14.3 from hmaarrfk:rebuild_1.14.3

Nov 29, 2024

Contributor

hmaarrfk commented Nov 6, 2024 •

edited

Loading

I'm tying to revert the changes done in
#231

while keeping it updated with some recent improvements

Please discuss alternatives #240

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged) -- previous build number was 5, now it is set to 6
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Create a maintenance branch 1.14.3
Retarget this PR to the 1.14.3 branch
Merge
Add the 1.14.3 to the bot's migration branches

Contributor

conda-forge-admin commented Nov 6, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

hmaarrfk force-pushed the rebuild_1.14.3 branch 2 times, most recently from 52ccb6a to e1b594f Compare

November 7, 2024 01:09

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

recipe/build.sh Outdated Show resolved Hide resolved

hmaarrfk commented

View reviewed changes

Contributor Author

hmaarrfk left a comment

revert frivolous changes


          Try to rebuild 1.14.3

e11914a

I'm tying to revert the changes done in
conda-forge#231

while keeping it updated with some recent improvements

Please discuss in conda-forge#240

- [ ] Build number maintained

hmaarrfk force-pushed the rebuild_1.14.3 branch from 0c9c3d2 to e11914a Compare

November 7, 2024 13:54

hmaarrfk mentioned this pull request

UTF-8 unusable on windows with 1.14.4 - 1.14.5 #240

Open

1 task

hmaarrfk changed the base branch from main to 1.14.3

November 19, 2024 05:17


          MNT: Re-rendered with conda-build 24.9.0, conda-smithy 3.44.6, and co…

233edf0

…nda-forge-pinning 2024.11.18.19.00.37

hmaarrfk force-pushed the rebuild_1.14.3 branch from beff963 to 233edf0 Compare

November 19, 2024 05:21

hmaarrfk marked this pull request as ready for review

November 19, 2024 05:25

hmaarrfk requested review from SylvainCorlay, astrofrog, davidbrochart, gillins, groutr, jakirkham and marcelotrevisani as code owners

November 19, 2024 05:25

hmaarrfk requested review from ocefpaf, scopatz, varlackc and zklaus as code owners

November 19, 2024 05:25

Contributor Author

hmaarrfk commented Nov 19, 2024

Given the little activity in #240 I plan to merge this in 2 days.

hmaarrfk merged commit 7f57e4d into conda-forge:1.14.3

23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

astrofrog Awaiting requested review from astrofrog astrofrog is a code owner

davidbrochart Awaiting requested review from davidbrochart davidbrochart is a code owner

gillins Awaiting requested review from gillins gillins is a code owner

groutr Awaiting requested review from groutr groutr is a code owner

jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

marcelotrevisani Awaiting requested review from marcelotrevisani marcelotrevisani is a code owner

ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

scopatz Awaiting requested review from scopatz scopatz is a code owner

varlackc Awaiting requested review from varlackc varlackc is a code owner

zklaus Awaiting requested review from zklaus zklaus is a code owner

Labels

None yet