Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests for programs with .py extension #941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

plimkilde
Copy link
Contributor

@plimkilde plimkilde commented May 29, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Just noticed that the .py extension has recently been removed from the GDAL docs of Python programs. As a followup to #934, ditch the tests of calls with .py.

There are currently 3 programs for which the docs still have .py, I've opened this PR to fix that. Now merged

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@gillins
Copy link
Contributor

gillins commented May 31, 2024

So this would break code for anyone still calling the .py extension versions? Perhaps we should wait a little longer before doing this. We perhaps need to print a warning when the old ones are called, not sure how easy that would be....

@rouault
Copy link
Contributor

rouault commented May 31, 2024

So this would break code for anyone still calling the .py extension versions?

no, the .py scripts are still there, and there's no plan to remove them. It is just that the recommended way is to use the non-suffixed launcher.

@gillins
Copy link
Contributor

gillins commented May 31, 2024

Thanks @rouault - ah right it's just the tests that we are removing. But - perhaps they need to stay in until they are removed from GDAL? So we can be sure they aren't broken?

@rouault
Copy link
Contributor

rouault commented May 31, 2024

But - perhaps they need to stay in until they are removed from GDAL?

I'm fine with either option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants