-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from pin_compatible
to explicit exclusion of nightly versions
#193
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- dask-core {{ version }}.*,!={{ version }}a.* | ||
- distributed {{ version }}.*,!={{ version }}a.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding here is that nightly versions get parsed by conda as something like 2022.8.1a.220805
, so the wildcard exclusion here should always be valid, I just think for some reason conda isn't a fan of exclusion wildcards without the .
; either way, I've opened conda/conda#11744 to document this behavior.
Appreciate the persistence in trying to get things working correctly here Charles 🙏 Am having trouble following why In any event it feels like we are going to a lot of work to avoid using strict channel priority, which is what we should ideally be using here. It may be worth taking a deeper look at how we can move to strict channel priority to avoid these kinds of issues. Potentially another kludge (if we can't get strict channel priority to work) is just to prepend the channel we want on to the relevant packages. Though am really hoping we can find a cleaner solution (like strict channel priority). |
Based on the version ordering scheme outlined here, I would think this is expected behavior? IIUC, the two versions would parse out to something like
And then I'm also in favor of figuring out how to unblock strict channel priority so that the solution doesn't have to be a Dask specific thing, my main reason for pushing on this as a short-term fix is due to an unclear time table on how long it would take to sort out strict channel priority for RAPIDS-Dask. Would you be okay with merging something like this in for now, with a medium-term goal of hashing out strict channel priority so that we can remove these constraints down the line? |
Turns out we need a tighter pinning than what (from my understanding)
pin_compatible
is able to generate - for example, generated pinning>=2022.8.1,<2022.8.2.0a0
would allow us to install dask 2022.8.1 with 2022.8.2a packages.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)