Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask-core / distributed pinning to properly exclude nightlies #191

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Fix dask-core / distributed pinning to properly exclude nightlies #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acb5fd7
Fix `dask-core` / `distributed` pinning to properly exclude nightlies
charlesbluca Aug 16, 2022
9d54c20
Use `pin_constrained` to exclude nightly versions
charlesbluca Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,18 @@ source:
sha256: a14c1c5143081701d4fe62283e09cc5ad5336dff3a152de64eb77ee3180e9792

build:
number: 1
number: 2
noarch: python

requirements:
host:
- python >=3.8
- dask-core {{ version }}
- distributed {{ version }}
run:
- python >=3.8
- dask-core ={{ version }},!={{ version }}a*
- distributed ={{ version }},!={{ version }}a*
- {{ pin_compatible('dask-core', max_pin='x.x.x') }}
- {{ pin_compatible('distributed', max_pin='x.x.x') }}
Comment on lines +23 to +24
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the current version, this would generate the following constraints:

    - dask-core >=2022.8.0,<2022.8.1.0a0
    - distributed >=2022.8.0,<2022.8.1.0a0

One edge case @jakirkham noted that this wouldn't cover is nightly packages of security backports (i.e. something like 2022.8.0.1a20220819; however, given the fact that it seems unlikely we would need to generate nightlies from backports, I think this is a reasonable solution.

- cytoolz >=0.8.2
- lz4
- numpy >=1.18
Expand Down