Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dask dependency #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jul 5, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [n/a] Reset the build number to 0 (if the version changed)
  • [n/a] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • [n/a] Ensured the license file is being packaged.

@ericpre ericpre requested review from jakirkham and ocefpaf as code owners July 5, 2023 13:20
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric! 🙏

Think this would be best handled upstream first and then this could be updated accordingly in a subsequent release

@ericpre
Copy link
Member Author

ericpre commented Jul 6, 2023

Thank you @jakirkham for the review. What does it need to handle upstream? As I understand the conda-forge dask-core package is the equivalent of installing dask without any extras:

dask: https://github.com/dask/dask/blob/461355e117958354ed30e29893afecd5e9258ff0/pyproject.toml#L29-L45
dask-core-feedstock: https://github.com/conda-forge/dask-core-feedstock/blob/e3cfc3964322f9421c7eed04af30d8e8924edddb/recipe/meta.yaml#L26-L35

The equivalent of the conda-forge dask package is dask['complete'], the conda-forge dask package has more dependencies (cytoolz and bokeh):

https://github.com/dask/dask/blob/461355e117958354ed30e29893afecd5e9258ff0/pyproject.toml#L65-L68
https://github.com/conda-forge/dask-feedstock/blob/c4a13519927e95614a24285ebb06916dd9b369fc/recipe/meta.yaml#L22-L31

@jakirkham
Copy link
Member

Referring to dask-cuda's source as upstream (as indicated by the link above)

@ericpre
Copy link
Member Author

ericpre commented Jul 6, 2023

Sorry, I don't understdand what needs to be change upstream: dask-cuda have dask (not dask['complete']) as dependency and this would translate to use dask-core in conda-forge.
For example, when installing dask-cuda from pypi, pyarrow and bokeh will not be installed, while it will be installed when installing from conda-forge. This is why dask-core need to be used instead of dask in conda-forge.

@jakirkham
Copy link
Member

jakirkham commented Jul 6, 2023

Could you please start by raising this as an issue on the dask-cuda repo? Think this will be easier to discuss there

@ericpre
Copy link
Member Author

ericpre commented Jul 6, 2023

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants