Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache of run file and copy to destination if folder already existed #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

diegoferigo
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@AgrawalAmey
Copy link
Contributor

Hi @diegoferigo, thanks is great! Do you want to also add the -c option for wget in the same PR? Thanks a lot fixing this

@nnkwame
Copy link
Contributor

nnkwame commented Dec 26, 2021

Thanks a lot for your help @diegoferigo . In the case where the download file exists, there is the possibility that the existing file is incomplete. I think possible options are:

  • to combine adding the resume options to the wget and curl calls (respectively -c and -C -) as pointed out by @AgrawalAmey with performing the download operation even in the case of the file already existing. (recommended)
  • to check additionally that the checksum matches with the desired file‘s checksum, in the branch where the download is not performed. However this requires that the checksum be added from the nvidia page containing the checksums, for the comparison.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants