Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender #88

Merged

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Oct 15, 2024

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #87.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #87

xref: conda-forge/cupy-feedstock#289

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11337194637.

Now that the CUDA 12.0 migrator is closed, the vendored migrator
included here needs some updates to reflect CUDA 12.0's inclusion in the
global pinnings.
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@conda-forge-admin conda-forge-admin marked this pull request as ready for review October 15, 2024 00:53
Make sure the `skip` condition rules out any `cuda_compiler_version`
specified as `<major>.<minor>`. This way we are always build with the
latest CUDA version when building `cuda-python`.
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham
Copy link
Member

jakirkham commented Oct 15, 2024

The GitHub autogenerated archive's checksum changed. Here is an example error from this CI build

Downloading source to cache: v12.6.0_4b7f81ca48.tar.gz
Downloading https://github.com/NVIDIA/cuda-python/archive/refs/tags/v12.6.0.tar.gz
Success
Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 11, in <module>
    sys.exit(execute())
  File "/opt/conda/lib/python3.10/site-packages/conda_build/cli/main_build.py", line 589, in execute
    api.build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 209, in build
    return build_tree(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3655, in build_tree
    packages_from_this = build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2446, in build
    try_download(m, no_download_source=False, raise_error=True)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/render.py", line 762, in try_download
    source.provide(metadata)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 1035, in provide
    unpack(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 169, in unpack
    src_path, unhashed_fn = download_to_cache(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/source.py", line 125, in download_to_cache
    raise RuntimeError(
RuntimeError: SHA256 mismatch: 'd86d4e64f4b8a037260dfc49df2a12f86c668a2137aa8f57be4dc658eb85401f' != '4b7f81ca48e91c3af58857641115da294885126f00f0b72e3c87db5ed8549ff3'

For a resolution to checksum changes, please see upstream issue: NVIDIA/cuda-python#71

Edit: For now refreshed the checksum and bumped the build/number with commit ( 57e6466 )

@jakirkham jakirkham removed the automerge Merge the PR when CI passes label Oct 15, 2024
@jakirkham jakirkham added the automerge Merge the PR when CI passes label Oct 15, 2024
@jakirkham
Copy link
Member

Windows builds appear to be failing. For example please see this CI error:

  Traceback (most recent call last):
    File "D:\bld\cuda-python_1728956254804\_h_env\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
      main()
    File "D:\bld\cuda-python_1728956254804\_h_env\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "D:\bld\cuda-python_1728956254804\_h_env\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 149, in prepare_metadata_for_build_wheel
      return hook(metadata_directory, config_settings)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "D:\bld\cuda-python_1728956254804\_h_env\Lib\site-packages\setuptools\build_meta.py", line 373, in prepare_metadata_for_build_wheel
      self.run_setup()
    File "D:\bld\cuda-python_1728956254804\_h_env\Lib\site-packages\setuptools\build_meta.py", line 318, in run_setup
      exec(code, locals())
    File "<string>", line 177, in <module>
  AttributeError: module 'distutils._msvccompiler' has no attribute 'PLAT_TO_VCVARS'
  error: subprocess-exited-with-error
  
  Preparing metadata (pyproject.toml) did not run successfully.
  exit code: 1
  
  See above for output.
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  full command: 'D:\bld\cuda-python_1728956254804\_h_env\python.exe' 'D:\bld\cuda-python_1728956254804\_h_env\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py' prepare_metadata_for_build_wheel 'C:\Users\VSSADM~1\AppData\Local\Temp\tmpg7x7wrcf'
  cwd: D:\bld\cuda-python_1728956254804\work
  Preparing metadata (pyproject.toml): finished with status 'error'
error: metadata-generation-failed

It looks like Distutils switched to dynamically generating PLAT_TO_VCVARS ( pypa/distutils#285 ), which Setuptools incorporated into its vendored copy of distutils ( pypa/setuptools#4606 ) starting with Setuptools 74.0.0. The error indicates PLAT_TO_VCVARS is not being generated for some reason, but it is unclear why

Will try pinning to an older setuptools for now

@leofang
Copy link
Member

leofang commented Oct 15, 2024

Thanks for looking into the rerendering issue, John!

The error indicates PLAT_TO_VCVARS is not being generated for some reason, but it is unclear why

Yeah @vzhurba01 had looked into it and he fixed this in cuda-python 12.6.1 (here), so it makes sense that we ping at an older setuptools for now and revert it later in the 12.6.1 PR.

@jakirkham
Copy link
Member

Thanks Leo! 🙏

Did not realize we were changing PLAT_TO_VCVARS. Am glad to see that is no longer needed

Sounds good

@jakirkham jakirkham removed the automerge Merge the PR when CI passes label Oct 15, 2024
@jakirkham
Copy link
Member

Ok that pin seems to be working. Will try adding back automerge

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Oct 15, 2024
@github-actions github-actions bot merged commit bea44d1 into conda-forge:main Oct 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin , please re-render
3 participants