-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda-forge.yml version numbers should be string, not float #76
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yannik! 🙏
Had some questions below
@@ -4,7 +4,7 @@ azure: | |||
swapfile_size: 10GiB | |||
bot: | |||
abi_migration_branches: | |||
- 11.8 | |||
- '11.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am curious, why was this not read as a string before?
Though the bot was previously reading this ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The context is at conda-forge/conda-smithy#1756 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I was under the impression that all values in conda-forge.yml
are strings (ex: we have 10GiB
above), so adding quotations or not does not make differences. Since when was this changed? I've read the linked issue but it was unclear to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML parsers try to interpret some numerical values as floats (presumably those conforming to some regex, or something like that). The “GiB” part of the 10GiB value makes it parse as a string. This was a big problem when Python 3.10 came out because many YAML files had - 3.10
which was interpreted as 3.1.
This fix seems reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for letting me know the parser quirks...
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)To ensure compatibility with the new Pydantic schema of conda-smithy, version numbers should be strings, not floats in
conda-forge.yml
. Refer to conda-forge/conda-smithy#1756 (comment)