-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target libraries/executables to executable's RPATH #29
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
abc8214
to
4669f32
Compare
Seeing the following warning on CI
Can we take a closer look at how |
…nda-forge-pinning 2024.11.05.21.36.17
4669f32
to
2ebc6ea
Compare
This is all set w/ latest commit pushed - there is no longer 'not found' warning in the output for all platforms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Billy! 🙏
Had a couple minor suggestions below
Generally this seems reasonable
recipe/build.sh
Outdated
# Do not patch libnvvm.so for now as it gets corrupted by patchelf. See build.sh for details | ||
#elif [[ "${j}" =~ /lib.*/.*\.so($|\.) && ! -L "${j}" ]]; then | ||
# echo patchelf --force-rpath --set-rpath "\$ORIGIN" "${j}" ... | ||
# patchelf --force-rpath --set-rpath "\$ORIGIN" "${j}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment references build.sh
for details however this is in build.sh
. Are there more details we should add here or can that portion be dropped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant meta.yaml, not build.sh, sorry. But after taking a closer look at how this came about, I found conda-forge/staged-recipes@94a71a6 which was to set binary_relocation to false in order to fix the corruption issue. Therefore I will uncomment the block and patch libnvvm.so. Thank you for raising the question on this!
The corruption they were referring to is conda-forge/staged-recipes#22802 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Ready for review.
Co-authored-by: jakirkham <[email protected]>
cicc was not being patched - it is all set now |
The outstanding questions have been resolved. |
Thanks Billy! 🙏 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)These files will be patched:
targets/x86_64-linux/bin/__nvcc_device_query
targets/x86_64-linux/bin/bin2c
targets/x86_64-linux/bin/cudafe++
targets/x86_64-linux/bin/fatbinary
targets/x86_64-linux/bin/nvcc
targets/x86_64-linux/bin/nvlink
targets/x86_64-linux/bin/ptxas
These will be skipped:
patchelf
targets/x86_64-linux/bin/crt/link.stub
targets/x86_64-linux/bin/crt/prelink.stub
targets/x86_64-linux/bin/nvcc.profile
Added recipe/patchelf_exclude.txt to exclude files to patch as they aren't binaries. The conda build will fail if a new binary is added without updating this file.
xref: conda-forge/cuda-feedstock#10