Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for CUDA 12.2.2 #32

Merged
merged 6 commits into from
Jan 6, 2024
Merged

Update for CUDA 12.2.2 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
281f422
Update for CUDA 12.2.2
adibbley Dec 18, 2023
b330aca
Add cuda-crt and cuda-nvvm metapackages
adibbley Dec 19, 2023
f3fc3c7
Update crt summary
adibbley Dec 19, 2023
8af24b0
Merge remote-tracking branch 'upstream/main' into cuda-12.2.2
bdice Jan 4, 2024
ecf3a3e
Reset build number.
bdice Jan 4, 2024
5a2894e
MNT: Re-rendered with conda-build 3.28.2, conda-smithy 3.30.2, and co…
Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 31 additions & 15 deletions README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

55 changes: 52 additions & 3 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% set name = "cuda-nvcc-split" %}
{% set version = "12.1.105" %}
{% set cuda_version = "12.1" %}
{% set version = "12.2.140" %}
{% set cuda_version = "12.2" %}
adibbley marked this conversation as resolved.
Show resolved Hide resolved

package:
name: {{ name|lower }}
Expand All @@ -12,7 +12,7 @@ source:
sha256: 5db25d4fd138013b563f9a3d1d87f7de7df1dac014fd4cccdfbb3435a5cff761

build:
number: 1
number: 0
skip: true # [osx]
skip: true # [target_platform != "linux-64" and target_platform != cross_target_platform]

Expand Down Expand Up @@ -94,6 +94,55 @@ outputs:
Compiler for CUDA applications.
doc_url: https://docs.nvidia.com/cuda/index.html

- name: cuda-crt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a cuda-crt-dev either here or in cuda-nvcc-impl, which pulls in cuda-crt-dev_{{ target_platform }}? This may also be a bit more ergonomic

This would be somewhat similar to what we did with cuda-cudart-dev. Though that has a few more pieces to pull in

Understand if this feels redundant. Mainly wanted to surface the suggestion so we could make a decision either way

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong opinions here. I am okay with the current implementation.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, no strong opinion here. All of these details should be hidden from the user anyway, so I'd say we hold off on adding more packaging indirection until we see more benefits for us as maintainers. Right now I think the tradeoff of clarity for volume is pretty even.

build:
skip: True # [target_platform != cross_target_platform]
requirements:
run:
- cuda-crt-dev_{{ target_platform }} {{ version }}.*
- cuda-crt-tools {{ version }}.*
test:
commands:
- test -f $PREFIX/bin/crt/link.stub # [linux]
- if not exist %LIBRARY_BIN%\crt exit 1 # [win]
about:
home: https://developer.nvidia.com/cuda-toolkit
license_file: LICENSE.txt
license: LicenseRef-NVIDIA-End-User-License-Agreement
license_url: https://docs.nvidia.com/cuda/eula/index.html
summary: CUDA internal headers.
description: |
CUDA internal headers.
doc_url: https://docs.nvidia.com/cuda/index.html

- name: cuda-nvvm
build:
skip: True # [target_platform != cross_target_platform]
requirements:
run:
- cuda-nvvm-dev_{{ target_platform }} {{ version }}.*
- cuda-nvvm-tools {{ version }}.*
- cuda-nvvm-impl {{ version }}.*
test:
commands:
- test -f $PREFIX/nvvm/bin/cicc # [linux]
- test -d $PREFIX/nvvm/libdevice # [linux]
- test -d $PREFIX/nvvm/include # [linux]
- test -d $PREFIX/nvvm/lib64 # [linux]
- if not exist %LIBRARY_PREFIX%\nvvm\bin\cicc.exe exit 1 # [win]
- if not exist %LIBRARY_PREFIX%\nvvm\libdevice exit 1 # [win]
- if not exist %LIBRARY_PREFIX%\nvvm\include exit 1 # [win]
- if not exist %LIBRARY_PREFIX%\nvvm\lib exit 1 # [win]
about:
home: https://developer.nvidia.com/cuda-toolkit
license_file: LICENSE.txt
license: LicenseRef-NVIDIA-End-User-License-Agreement
license_url: https://docs.nvidia.com/cuda/eula/index.html
summary: Compiler for CUDA applications.
description: |
Compiler for CUDA applications.
doc_url: https://docs.nvidia.com/cuda/index.html

about:
home: https://developer.nvidia.com/cuda-toolkit
license_file: LICENSE.txt
Expand Down
Loading