-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing run_exports in cuda-cupti-dev #10
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.22.16.02.30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this looks like an oversight on our part. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
As a note: I double-checked the SONAME / version compatibility of cupti. Prior to CUDA 12, linking to libcupti
would break CUDA Enhanced Compatibility (runtime compatibility within the same major version) because it required the same major.minor version of CUDA. It seems that restriction has been lifted in CUDA 12.0 and later. That would've meant we needed different compatibility rules here but I think we are all good.
We're doing a bit more investigation here as to whether there are issues with CEC in the rest of the dependency tree here. |
There are some subtleties around usage of cupti because some of its features involve other packages like nvperf that do not fully support CEC yet, and would therefore necessitate different pinnings in the run export. However, standalone usage of cupti is safe, so we're good with merging this PR for now and improving documentation of those edge cases over time. |
Thanks a lot! |
Fix #9
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)