Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable binary_relocation in cuda-cudart_{{ target_platform }} #10

Merged
merged 4 commits into from
May 23, 2023

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented May 23, 2023

Disable binary_relocation in cuda-cudart_{{ target_platform }} as the libraries wind up being broken by the patching process. Also they are already relocatable.


Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #9

Disable `binary_relocation` in `cuda-cudart_{{ target_platform }}` as
the libraries wind up being broken by the patching process. Also they
are already relocatable.
Rebuild `cuda-cudart_{{ target_platform }}` packages with unpatched
libraries so they behave as expected.
@jakirkham jakirkham requested a review from adibbley as a code owner May 23, 2023 19:32
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like I wasn't able to push to the turn_off_bin_reloc branch of jakirkham-feedstocks/cuda-cudart-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-cudart-feedstock/actions/runs/5061324632.

@jakirkham
Copy link
Member Author

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-cudart-feedstock/actions/runs/5061428751.

…, and conda-forge-pinning 2023.05.23.18.17.57"

This reverts commit 3cf4cb8.

Appears to be dropping some package outputs that we may not want to drop
from the README.
@adibbley adibbley merged commit 1295421 into conda-forge:main May 23, 2023
@jakirkham jakirkham deleted the turn_off_bin_reloc branch May 23, 2023 20:40
@jakirkham
Copy link
Member Author

Thanks Alex! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libcudart.so.12.0.107: ELF load command address/offset not properly aligned
2 participants