-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No ctng and build GCC 10, 11 #53
Conversation
…nda-forge-pinning 2021.07.11.12.10.29
…nda-forge-pinning 2021.07.15.07.57.26
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
…nda-forge-pinning 2021.07.15.07.57.26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
My main concern here is that we will get a different layout of the files between the different split packages and that will break the compilers if we mix stuff built by crosstool-ng and the gcc build.
It looks like you beefed up the tests a bit to make sure each package has the files it is supposed to have. Should we do more of that?
The differences are in |
Ahhh great! Then as long as the compilers work, we should be good to go! |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want to keep the -ng
in the package names? Maybe we remove once a new gcc feedstock is created?
I don't mind keeping it as it might be disruptive to remove. Besides I don't think |
Let me know if you think this is good to merge and I'll fix some things up and merge. |
LGTM! |
…nda-forge-pinning 2021.07.22.10.53.36
cc @beckermr, @chenghlee, @katietz, @ocefpaf
This is the first to step to remove crosstool-ng and build gcc directly using
./configure && make
.The reason to remove crosstool-ng is it's hard to work with and building cross-native or canadian cross compilers is hard. (It's possible, but hard). It's also building the sysroot and binutils redundantly because we build them elsewhere.
I've only added the bare minimum to make this work. I intend to do some more refactoring like
ctng_gcc->gcc_version
, butI've hold off on that to make the review easier. (I'll also add cross-native compilers in a separate PR)
I've also added
conda-forge/label/gcc_dev
so that these compilers are not uploaded tomain
right now, so that I can play withthem for a while. When this PR is ready to be merged, I'll make a
gcc-feedstock
through staged-recipes.Closes #50
Fixes #55