Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3.13 build #79

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Conversation

akrherz
Copy link
Contributor

@akrherz akrherz commented Aug 29, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Ignorantly trying a python 3.13 build.
closes #78
@conda-forge-admin please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@akrherz
Copy link
Contributor Author

akrherz commented Aug 29, 2024

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits August 29, 2024 01:39
@akrherz
Copy link
Contributor Author

akrherz commented Aug 29, 2024

@conda-forge-admin please rerender

hmaarrfk added a commit to hmaarrfk/conda-forge-pinning-feedstock that referenced this pull request Aug 29, 2024
@akrherz
Copy link
Contributor Author

akrherz commented Aug 29, 2024

It is unclear to me why this worked on one OSX arch, but on none of the others. Is repo metadata not fully updated yet? https://conda-metadata-app.streamlit.app/ seems to show it. Anybody please feel free to push over what I have done here.

@jakirkham
Copy link
Member

As this is still needed for Python 3.13, we've paused the migrator for now: conda-forge/conda-forge-pinning-feedstock#6361

cc @conda-forge/core

@h-vetinari
Copy link
Member

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member

It is unclear to me why this worked on one OSX arch, but on none of the others

Because we don't run tests on osx-arm, the runtime environment never gets resolved, so this didn't trigger.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we could drop all of

version:
  - 3.8
  - 3.9
  - 3.7
  - 3.8
py_impl:
  - 73_pypy
  - 73_pypy
  - cpython
  - cpython

here, as we no longer build for those python versions.

@isuruf
Copy link
Member

isuruf commented Aug 29, 2024

@conda-forge-admin, rerender

@isuruf isuruf added the automerge Merge the PR when CI passes label Aug 29, 2024
@github-actions github-actions bot merged commit 79bbf75 into conda-forge:main Aug 29, 2024
38 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@akrherz akrherz deleted the gh21_python313 branch August 29, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is python 3.13 support coming?
4 participants