feat: add lint+hint for recipe parsing #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@conda-forge/core this one is ready for review! |
18 tasks
jaimergp
reviewed
Nov 19, 2024
jaimergp
reviewed
Nov 19, 2024
Comment on lines
+1029
to
+1032
| with tempfile.TemporaryDirectory() as tmpdir: | ||
| recipe_file = os.path.join(tmpdir, "meta.yaml") | ||
| with open(recipe_file, "w") as f: | ||
| f.write(recipe_text) |
There was a problem hiding this comment.
Souschef modifies the recipe file on parsing? 🤔
There was a problem hiding this comment.
Likely not but why take the risk?
jaimergp
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)This PR is a good step for moving towards v1 recipes. We'll need recipes to be able to be parsed by CRM in order to try automatic conversion. I also included the bot's parser and the one used by grayskull.
closes #2140