document gpu/long-running builds #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
approved these changes
Dec 4, 2023
|
Thanks |
jakirkham
reviewed
Dec 5, 2023
| Due to some technical and legal limitations, some of the usual automation infrastructure is not available for these runners. | ||
| As mentioned above, the conda-forge bots won't be able to rerender your feedstock automatically anymore. | ||
| Automerge will not function properly either. Also note that the conda-forge bots won't be able to trigger the self-hosted runners. | ||
| Closing and reopening the PR won't work, but a maintainer with sufficient permissions can trigger it manually by pushing an empty commit. |
There was a problem hiding this comment.
Am curious why closing and reopening won't work? In that case we would be able to check to see if the user closing and reopening the PR is authorized right?
There was a problem hiding this comment.
The event payload used for the authentication is based on the last commit pushed, not the most recent event, afaicu. cc @aktech for confirmation
There was a problem hiding this comment.
This has been updated in the latest deployment (since yesterday), closing and opening PR (by authorized user) would work now, as the sender of the event is the one who has permissions.
Comment on lines
+1865
to
+1866
| 1. Go to the ``conda-forge/admin-requests`` repo and copy `examples/example-broken.yml <https://github.com/conda-forge/admin-requests/blob/main/examples/example-broken.yml>`__ to the ``requests/`` folder. | ||
| 2. Add the name of your feedstock in the YML file. While adding the name, don't add "-feedstock" to the end of it. For example: for ``python-feedstock``, just add ``python``. |
There was a problem hiding this comment.
Wonder if we can tighten this up a bit
Suggested change
| 1. Go to the ``conda-forge/admin-requests`` repo and copy `examples/example-broken.yml <https://github.com/conda-forge/admin-requests/blob/main/examples/example-broken.yml>`__ to the ``requests/`` folder. | |
| 2. Add the name of your feedstock in the YML file. While adding the name, don't add "-feedstock" to the end of it. For example: for ``python-feedstock``, just add ``python``. | |
| 1. Go to the ``conda-forge/admin-requests`` repo | |
| 2. Copy and rename `examples/example-broken.yml <https://github.com/conda-forge/admin-requests/blob/main/examples/example-broken.yml>`__ to the ``requests/`` folder. | |
| 3. Add the feedstock name (without the "-feedstock") in the YML file. For example: ``python-feedstock`` would be ``python``. |
There was a problem hiding this comment.
Yep, let's open a new PR!
Comment on lines
+258
to
260
| 2. Fork `conda-forge/admin-requests <https://github.com/conda-forge/admin-requests>`__ and add a new YML file in the ``requests`` directory. | ||
| 3. Add the broken files to the new YML document.See `examples/example-broken.yml <https://github.com/conda-forge/admin-requests/blob/main/examples/example-broken.yml>`__ for an example file. | ||
| 4. Open a new PR. Once merged, a bot will label all listed files as broken, thus effectively removing them from the channel. |
There was a problem hiding this comment.
Suggested change
| 2. Fork `conda-forge/admin-requests <https://github.com/conda-forge/admin-requests>`__ and add a new YML file in the ``requests`` directory. | |
| 3. Add the broken files to the new YML document.See `examples/example-broken.yml <https://github.com/conda-forge/admin-requests/blob/main/examples/example-broken.yml>`__ for an example file. | |
| 4. Open a new PR. Once merged, a bot will label all listed files as broken, thus effectively removing them from the channel. | |
| 2. Fork `conda-forge/admin-requests <https://github.com/conda-forge/admin-requests>`__ | |
| 3. Create a new YML file in the ``requests`` directory. | |
| 3. Add the broken package files to the new YML document. See `examples/example-broken.yml <https://github.com/conda-forge/admin-requests/blob/main/examples/example-broken.yml>`__ for an example file. | |
| 4. Open a new PR. | |
| Once merged, a bot will label all listed files as broken, thus effectively removing them from the channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
Documentation here is minimal for now, but instead it points towards the resources where more information can be found. We'll make sure to keep the "gotchas" note up-to-date as we discover workarounds.
See also conda-forge/admin-requests#886
cc @isuruf