-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency on cuda-cupti for CUDA 12 jaxlib builds #725
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
I rebased on top of main, and now the diff is the expected one:
The PR is ready for review @conda-forge/core, thanks! |
fyi @conda-forge/jax @conda-forge/cuda-cupti if you have any comment. |
This looks good but shouldn't we also have a PR that add this dependency to the |
In theory the right way to handle would be to add a run_exports to cuda-cupti, we already did that on 12.4 but 12.0 is actually used, see conda-forge/cuda-cupti-feedstock#14 . However, if we do not get feedback on conda-forge/cuda-cupti-feedstock#14 from @conda-forge/cuda-cupti probably we can just add the dependency on jaxlib itself. |
We should definitely add it immediately to |
Done: conda-forge/jaxlib-feedstock#251 . Or if you are working on another PR, feel free to add it in that PR. |
Fix for:
cuda-cupti-dev
cuda-cupti-feedstock#9Checklist
generate_patch_json.py
if absolutely necessary.pre-commit run -a
and ensured all files pass the linting checks.python show_diff.py
and posted the output as part of the PR.