-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update c_stdlib_version for aarch + cuda 12.6 #6745
Update c_stdlib_version for aarch + cuda 12.6 #6745
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict. Please ping the 'conda-forge/core' team (using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our previous attempt at building for CUDA 12.6 we had the c_stdlib version increased for aarch, and even linux64:
That's because at the time, we still had a coupling of c_stdlib_version
with docker_image
, and changing the image implied changing the stdlib. When using the newest docker images though (as we recently started doing), the bump to the c_stdlib_version
is not necessary anymore -- except for packages which fail during compilation against our default sysroot due to some missing symbols or somesuch.
To the best of my understanding, the situation in pytorch would not be changed by this PR.
- it happens at runtime, and not compilation time.
- it happens due to loading a dependency likely having incorrect metadata
- Even then the failure makes no sense (as I was trying to say in the comment you referenced), because the image that the build was running in was an alma8 image, which has a 2.28 glibc in it that is available (and should be the only one!).
The fact loading libcufile.so
fails to load with /lib64/libm.so.6: version 'GLIBC_2.27' not found
-- in other words, a symbol from an older glibc version than present in the image (and one that should thus definitely be there) -- to me sounds like something went seriously wrong somewhere (or perhaps alternatively, that I severely misunderstand some aspect of this).
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
OK, that got me thinking. I rechecked the logs (warning, large), and in the test environment, there's actually another glibc hiding:
So what this means, that loading So the immediate solution there is to add run_constrained:
- sysroot_{{ target_platform }} >={{ c_stdlib_version }} to |
ok i'll let you work with the cuda team to help streamline this and hopefully get to close conda-forge/cudnn-feedstock#85 |
I think this was missed in the cuda 12.6 upgrade.
In our previous attempt at building for CUDA 12.6 we had the c_stdlib version increased for aarch, and even linux64:
https://github.com/conda-forge/pytorch-cpu-feedstock/pull/293/files#diff-ff61408cdc05bc9667deeadb55e4aaceb1371972076b6bf6934f9008920f2bd2
cc: @h-vetinari
conda-forge/pytorch-cpu-feedstock#293 (comment)
Closes: conda-forge/cudnn-feedstock#85
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)