Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a linter hint for xorg-proto packages #6688

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

hmaarrfk
Copy link
Contributor

@pkgw I think this is not the ideal way, but we have been using the newer proto on some new recipes and I am noticing clobbering in a few environments. I think it would be fine to use this in lieu of a more complicated migration

Let me know what you think

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk requested a review from a team as a code owner November 13, 2024 04:04
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

Kind ping @pkgw

@pkgw I think this is not the ideal way, but we have been using the
newer proto on some new recipes and I am noticing clobbering in a few
environments. I think it would be fine to use this in lieu of a more
complicated migration
@pkgw
Copy link
Contributor

pkgw commented Dec 8, 2024

@hmaarrfk Sorry for being very slow to respond here. This seems like a fine start. There are of course many many other proto packages that could also be mentioned here, but Xext seems like one of the more common offenders. Maybe it would be good to also have a record for xorg-xproto, mainly because it seems like that one might be confusing for people due to the naming similarity.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 9, 2024

awesome. I just duplicated the message for both, and we'll see what happens over time.

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Dec 9, 2024
@conda-forge-admin conda-forge-admin merged commit 8147dc9 into conda-forge:main Dec 9, 2024
3 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • github-actions: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham
Copy link
Member

Started a discussion about a migrator for this case: regro/cf-scripts#3360

@jakirkham
Copy link
Member

Expanded this to include all xorg-*protos in PR: #6816

Please let me know what you think 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants