-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG fix zipping for c stdlib #5592
BUG fix zipping for c stdlib #5592
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.03.05.09.59.43
how is this proposed logic any different than before? they seem equivalent. |
Two changes
|
I was hoping we wouldn't have to have the compiler and stdlib in the same zip... Definitely the cdt needs to be zipped with the stdlib, but perhaps we can split that group out of the mega-zip, at least once we've dropped cos6 this summer. |
Possibly? I don't see the issue here really except that it makes matching things up somewhat error prone. |
It's not a big issue per se, but it gets hard to change anything non-trivial about such a large zip in a local CBC without running into breakages. Also conceptually, compiler and stdlib shouldn't have to be coupled. But again, not an issue for now. Thanks for fixing it! |
If we do this, we need to update the CUDA migrators too as they touch this key. Currently migration is broken on any CUDA feedstock ( for example: conda-forge/ucx-split-feedstock#158 (comment) ) That said, this kind of smells like a bug in conda-smithy cc @mbargull (in case you have any ideas 🙂) |
@@ -13,8 +13,8 @@ c_stdlib: | |||
- macosx_deployment_target # [osx] | |||
- vs # [win] | |||
c_stdlib_version: # [unix] | |||
- 2.12 # [linux64] | |||
- 2.17 # [aarch64 or ppc64le] | |||
- 2.12 # [linux and x86_64] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for CUDA this needs to be 2.17
(even on x86_64
)
Yeah, this is the kind of thing why I would have liked to avoid adding the stdlib into that mega-zip_keys... 😑 I think we'll have to duplicate much of the |
Oh no sorry! We have to zip it with cdt so we're stuck. How can I help fix things? I'm not sure what is needed. |
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #5591.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.
Fixes #5591