-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the same glibc version as the docker image for cross #368
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12208056492. Examine the logs at this URL for more detail. |
@conda-forge/core, this is ready for review |
Thanks, @isuruf! I just spent most of a day coming to the same conclusion. 😄 Closes conda-forge/pytorch-cpu-feedstock#299 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need a default somewhere or are we confident we'll always be able to find the __glibc
virtual package?
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Thank you for this, and for adding an explanatory comment! 🙏 |
# as the docker glibc. | ||
# For eg: when cross compiling for linux-aarch64 in a | ||
# docker image with linux-anvil-x86_64:alma9 image, we use | ||
# glibc=2.28 for QEMU while still building the package for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comment is slightly off - alma9 would yield a glibc of 2.34 through __glibc
; 2.28 goes with alma8.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)