Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the same glibc version as the docker image for cross #368

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Dec 6, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf requested a review from a team as a code owner December 6, 2024 09:18
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 6, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12208056492. Examine the logs at this URL for more detail.

@isuruf
Copy link
Member Author

isuruf commented Dec 6, 2024

@conda-forge/core, this is ready for review

@carterbox
Copy link
Member

carterbox commented Dec 6, 2024

Thanks, @isuruf! I just spent most of a day coming to the same conclusion. 😄

Closes conda-forge/pytorch-cpu-feedstock#299
Closes conda-forge/libcufile-feedstock#26
Closes conda-forge/libcufile-feedstock#27
Closes conda-forge/linux-sysroot-feedstock#63 ? Maybe? Would need to check that all the situations in this issue are cross-compile related.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need a default somewhere or are we confident we'll always be able to find the __glibc virtual package?

@isuruf isuruf added the automerge Merge the PR when CI passes label Dec 7, 2024
@conda-forge-admin conda-forge-admin merged commit 6eaffb4 into conda-forge:main Dec 7, 2024
43 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari
Copy link
Member

Thank you for this, and for adding an explanatory comment! 🙏

# as the docker glibc.
# For eg: when cross compiling for linux-aarch64 in a
# docker image with linux-anvil-x86_64:alma9 image, we use
# glibc=2.28 for QEMU while still building the package for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment is slightly off - alma9 would yield a glibc of 2.34 through __glibc; 2.28 goes with alma8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants