Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setuptools management #5

Merged
merged 1 commit into from
Jun 18, 2016
Merged

Avoid setuptools management #5

merged 1 commit into from
Jun 18, 2016

Conversation

jakirkham
Copy link
Member

As we manage packages through conda (not setuptools/pip), we need to side-step package management through other means. This is the recommended way ( see "Creating System Packages" ) to do this.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@frol frol merged commit 919908e into conda-forge:master Jun 18, 2016
@jakirkham jakirkham deleted the setuptools_args branch June 18, 2016 18:00
@jakirkham
Copy link
Member Author

Thanks @frol.

@frol
Copy link
Member

frol commented Jun 18, 2016

Thank you for spotting this! I thought I had fixed this thing in all contributed feedstocks.

@jakirkham
Copy link
Member Author

No worries. It's too easy to forget this or get it wrong. So, I started working on a package that would do this automatically. See this PR ( conda-forge/staged-recipes#642 ) for details.

Basically, it works on Mac and Linux, but some new features from conda/conda-build are required for it to work on Windows. The required Windows features exist in conda version 4.1.0 and conda-build 1.21.0. So, once we unpin conda-build. We should be able to explore this alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants