Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple Python versions in recipe #12

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

peanutfun
Copy link
Contributor

@peanutfun peanutfun commented Jul 15, 2024

Bump build number.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@peanutfun
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

We are not actually "building" anything.
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@peanutfun
Copy link
Contributor Author

peanutfun commented Jul 15, 2024

@emanuel-schmid I am not sure if this does the trick, but we can give it a try and see afterwards. If it does not work, I will ask a question in the conda-forge Q&A forum. I tried using conda_build_config.yaml, but this has no effect, because a Python package is technically not "built" (note that there is no "build" section in the meta.yaml either) edit: That's wrong, I just don't know if it had any effect 🤷

I just noticed that we did not release v4.1.1 yet. So, if we introduce an issue here, we can fix it right away afterwards and release v4.1.1 😉

@peanutfun peanutfun merged commit 5e8f225 into conda-forge:main Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant