Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.x] add missing pin to libcxx-devel; fix libcxx run-export #316

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[17.x] add missing pin to libcxx-devel; fix libcxx run-export #316

merged 2 commits into from
Sep 5, 2024

Conversation

h-vetinari
Copy link
Member

Backport #315

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Aug 29, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Aug 30, 2024
@h-vetinari h-vetinari changed the title [17.x] add missing pin to libcxx-devel [17.x] add missing pin to libcxx-devel; fix libcxx run-export Aug 30, 2024
@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Aug 30, 2024
@h-vetinari h-vetinari added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Aug 30, 2024
@h-vetinari h-vetinari force-pushed the devel_17 branch 2 times, most recently from f4a3bab to 224c5a9 Compare September 3, 2024 23:27
@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@h-vetinari h-vetinari removed the automerge Merge the PR when CI passes label Sep 4, 2024
@h-vetinari
Copy link
Member Author

Unpinning libcxx-devel here actually confuses the solver to the point that it cannot find a valid solution anymore. So I'm leaving the pins as is. We can revisit this if/once we rebuild this branch after moving our clang baseline to 18.

@h-vetinari h-vetinari merged commit 5d618d2 into conda-forge:17.x Sep 5, 2024
4 of 8 checks passed
@h-vetinari h-vetinari deleted the devel_17 branch September 5, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille Awaiting requested review from JohanMabille JohanMabille is a code owner

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

@chrisburr chrisburr Awaiting requested review from chrisburr chrisburr is a code owner

@inducer inducer Awaiting requested review from inducer inducer is a code owner

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@katietz katietz Awaiting requested review from katietz katietz is a code owner

@timsnyder timsnyder Awaiting requested review from timsnyder timsnyder is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@h-vetinari