Unvendor zlib #22
Merged
Unvendor zlib #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
|
@conda-forge-admin, please rerender |
|
@conda-forge-admin rerender |
…nda-forge-pinning 2020.04.26.19.17.14
|
@brianv0 and I have been discussing the state of the upstream dev. Hopefully we can get something to happen, but the ball is in my court right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)zlib is currently vendored in cfitsio. This PR unvendors zlib. I have been having some issues related to the vendoring.
openSUSE (https://build.opensuse.org/package/view_file/science/cfitsio/cfitsio-zlib.patch?expand=1) and ubuntu (https://launchpadlibrarian.net/439818280/cfitsio_3.450-3_3.470-3.diff.gz) have similar patches which are appropriate for their environments.