-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v0.22.0 #156
Update to v0.22.0 #156
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
I would appreciate at least one more set of eyes on: It would also be worth discussing if we want to make |
recipe/meta.yaml
Outdated
url: https://pypi.io/packages/source/C/Cartopy/Cartopy-{{ version }}.tar.gz | ||
sha256: 89d5649712c8582231c6e11825a04c85f6f0cee94dbb89e4db23eabca1cc250a | ||
url: https://github.com/SciTools/cartopy/archive/refs/tags/v{{ version }}.tar.gz | ||
sha256: 7adf6b92f4e16c46fb1ce58840275af7a6dc1f21d5243d4b665ecef72961f9f4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source is no longer being included on PyPI as discussed in #155
I will try to remind myself what the workaround for this is but in the meantime I've submitted an issue upstream: |
- scipy >=0.10 | ||
- ucrt # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scipy is only included as an extra in this version. I'm not sure what ucrt
was needed for but I didn't see any mention of it in this release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a universal C runtime and it was added in #116 (comment)
The CIs are passing so I'm OK leaving it out. Hopefully we won't break cartopy for Windows users :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zklaus, you were the one to recommend adding this library. It seemed to make CI pass at the time but doesn't seem to be needed now. I didn't find any mention of it (outside of people listing their environments) upstream: https://github.com/search?q=repo%3ASciTools%2Fcartopy+ucrt&type=issues
Do you think it's okay to remove it at this point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, @zklaus is on holiday this month
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. In that case maybe we assume the passing tests are a sign that this is no longer needed? It seemed like the PR where this was added indicated that the Win tests only passed after it was added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say merge and we can always add it back if someone reports it broken. Better to get this out there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add that cartopy isn't doing anything special here on building (just a bit of Cython at this point), so if it is somehow needed, it really should be something else exporting the requirement.
@conda-forge/cartopy, this is ready for review. |
A question is whether we're okay with switching to GitHub for the source as done here or if we want to wait for source to be uploaded to PyPI, see SciTools/cartopy#2228 (comment) |
I'm OK moving to GH and even moving back to PyPI after this release. Whatever you feel is easier. The only advantage to PyPI releases is that, some times, they are slimmer than the GH counterparts b/c authors remove some of the "fat." |
@ocefpaf, I also feel like bypassing |
I just uploaded the sdist to PyPI. |
Thanks @dopplershift! |
…nda-forge-pinning 2023.08.04.02.04.35
@conda-forge/cartopy, I have moved the source back to pypi and this is again ready for review (assuming tests pass). |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)closes #155