On Windows do not change the compilation option to MT

[traversaro]

All conda-forge libraries on Windows are compiled with the MD option, but bullet by default change that to MT, and this result in downstream linking errors such as:

2021-04-03T13:36:40.6871269Z BulletDynamics.lib(btRigidBody.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6879189Z BulletCollision.lib(btCollisionObject.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6880513Z BulletCollision.lib(btCollisionShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6881567Z BulletCollision.lib(btConvexShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6882739Z BulletCollision.lib(btDbvt.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6883781Z BulletCollision.lib(btPolyhedralConvexShape.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6885038Z BulletCollision.lib(btConvexPolyhedron.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6886027Z LinearMath.lib(btConvexHull.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6887059Z LinearMath.lib(btConvexHullComputer.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj
2021-04-03T13:36:40.6888094Z LinearMath.lib(btGeometryUtil.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in DARTDoublePendulum.cc.obj

Enabling the USE_MSVC_RUNTIME_LIBRARY_DLL CMake option ensure that Bullet uses the compilation flags used in the rest of conda-forge (see https://github.com/bulletphysics/bullet3/blob/db5be234dd2cc5471681663d04c9c3b247fc7e18/CMakeLists.txt#L100 ).

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[traversaro]

@conda-forge-admin, please rerender

[wolfv]

Thanks! I think we should move the previous build to broken

[traversaro]

Thanks! I think we should move the previous build to broken

Ack, let's wait to see if this instead is actually working properly, otherwise we add in broken also this one.

[wolfv]

btw maybe we should also add bullet to the conda-forge pinnings?

[traversaro]

Thanks! I think we should move the previous build to broken

Ack, let's wait to see if this instead is actually working properly, otherwise we add in broken also this one.

Done conda-forge/admin-requests#255 .

[traversaro]

btw maybe we should also add bullet to the conda-forge pinnings?

Not sure, what is the policy w.r.t. to that? Ideally any package with run_exports should be listed in the conda-forge pinnings?